You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/05/01 14:51:00 UTC
[jira] [Commented] (QPID-8305) [Broker-J][JDBC Message Store]
Performance regression when increasing the number of queues linked to a
topic
[ https://issues.apache.org/jira/browse/QPID-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831039#comment-16831039 ]
ASF GitHub Bot commented on QPID-8305:
--------------------------------------
alex-rufous commented on pull request #30: QPID-8305: [Broker-J][JDBC Message Store] Performance regression when increasing the number of queues linked to a topic
URL: https://github.com/apache/qpid-broker-j/pull/30#discussion_r280092297
##########
File path: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
##########
@@ -1151,25 +1153,27 @@ public MessageEnqueueRecord enqueueMessage(TransactionLogResource queue, Enqueue
final StoredMessage storedMessage = message.getStoredMessage();
if(storedMessage instanceof StoredJDBCMessage)
{
- _preCommitActions.add(new Runnable()
- {
- @Override
- public void run()
+ _preCommitActions.add(() -> {
+ try
{
- try
- {
- ((StoredJDBCMessage) storedMessage).store(_connWrapper.getConnection());
- _storeSizeIncrease += storedMessage.getContentSize();
- }
- catch (SQLException e)
- {
- throw new StoreException("Exception on enqueuing message into message store" + _messageId,
- e);
- }
+ ((StoredJDBCMessage) storedMessage).store(_connWrapper.getConnection());
+ _storeSizeIncrease += storedMessage.getContentSize();
}
+ catch (SQLException e)
+ {
+ throw new StoreException("Exception on enqueuing message into message store" + _messageId, e);
+ }
+ });
+ }
+ if(_messagesToEnqueue.isEmpty())
Review comment:
On-the-flight creation of pre-commit action for insertion of batch of aggregated enqueue records looks like hack to me.
I think that creation of such action in constructor of JBDCTransaction would make the code much simpler. Alternately, a special class to aggregate enqueued messages can be created where special methods to update and clean `_messagesToEnqueue` can be added. You can even create tests for the new class. You can create an instance of that special class in constructor of JDBCTransaction and invoke a method to append enqueued message from JBDCTransaction#enqueueMessage(). Potentially, a post commit action can even be created and executed in JBDCTransaction#doPreCommitActions. Though, that can complicate the code and make it less clean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> [Broker-J][JDBC Message Store] Performance regression when increasing the number of queues linked to a topic
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-8305
> URL: https://issues.apache.org/jira/browse/QPID-8305
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.1.0
> Reporter: Olivier VERMEULEN
> Priority: Major
>
> When sending a message to a topic, if this message is routed to N queues then we will do N+2 database inserts: 1 for the metadata, 1 for the content and 1 for each message/queue mapping (QPID_QUEUE_ENTRIES). The last N inserts could be batched in a single operation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org