[GitHub] [avro] emkornfield commented on a change in pull request #1106: Core C++ implementation is modernized

[GitBox <gi...@apache.org>]

emkornfield commented on a change in pull request #1106:
URL: https://github.com/apache/avro/pull/1106#discussion_r584369343



##########
File path: lang/c++/api/Compiler.hh
##########
@@ -46,17 +46,17 @@ AVRO_DECL void compileJsonSchema(std::istream &is, ValidSchema &schema);
 ///
 
 AVRO_DECL bool compileJsonSchema(std::istream &is, ValidSchema &schema,
-    std::string &error);
+                                 std::string &error);
 
-AVRO_DECL ValidSchema compileJsonSchemaFromStream(InputStream& is);
+AVRO_DECL ValidSchema compileJsonSchemaFromStream(InputStream &is);

Review comment:
       Is this reformat inline with the style guide? is there one for the C++ implementation.  At least in this file it seems the outlier is the one on line 48.

##########
File path: lang/c++/api/Decoder.hh
##########
@@ -47,11 +47,11 @@ namespace avro {
  */
 class AVRO_DECL Decoder {
 public:
-    virtual ~Decoder() { };
+    virtual ~Decoder() = default;;
     /// All future decoding will come from is, which should be valid
     /// until replaced by another call to init() or this Decoder is
     /// destructed.
-    virtual void init(InputStream& is) = 0;
+    virtual void init(InputStream &is) = 0;

Review comment:
       based on all the reformatting, it seems like the more accepted version is to put the reference with the type?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org