[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10681: [multistage]re-implement mailbox

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10681:
URL: https://github.com/apache/pinot/pull/10681#discussion_r1176761684


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/MailboxIdUtils.java:
##########
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.query.mailbox;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.pinot.query.runtime.operator.OpChainId;
+
+
+// TODO: De-couple mailbox id from query information
+public class MailboxIdUtils {

Review Comment:
   We want to de-couple mailbox id from query information (mailbox id should be just a UUID), and that is why we want to change it from an interface to just a string. Currently we still rely on some information from the mailbox id to create the `OpChainId`, so I added this util class to limit the scope of the change. Once we de-couple `OpChainId` from mailbox id, we should delete this util, and only use mailbox id as an identifier.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org