You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/10 20:18:07 UTC

[GitHub] [airflow] ryanahamilton opened a new pull request #12267: Fix pause/unpause toggle failed state when unsuccessful

ryanahamilton opened a new pull request #12267:
URL: https://github.com/apache/airflow/pull/12267


   Fixes a regression that broke the failed toggle state originally added in #7669. The regression was introduced by my toggle overhaul in #11035 where I overlooked (wasn't aware of) this functionality.
   
   Here's what this failed state looks like when request is unsuccessful:
   
   ![Screen Recording 2020-11-10 at 01 54 08 PM](https://user-images.githubusercontent.com/3267/98728275-4586d500-2367-11eb-83a8-ee73b49c99a8.gif)
   
   This should be cherry-picked into 2.0.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #12267: Fix pause/unpause toggle failed state when unsuccessful

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12267:
URL: https://github.com/apache/airflow/pull/12267#issuecomment-724945346


   The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #12267: Fix pause/unpause toggle failed state when unsuccessful

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12267:
URL: https://github.com/apache/airflow/pull/12267


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org