You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sc...@apache.org on 2006/06/07 13:59:21 UTC
svn commit: r412381 -
/myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Author: schof
Date: Wed Jun 7 04:59:21 2006
New Revision: 412381
URL: http://svn.apache.org/viewvc?rev=412381&view=rev
Log:
merged Dennis' commit (r412012) up to the branch since its needed for the tomahawk 1.0.3 release
Modified:
myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Modified: myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
URL: http://svn.apache.org/viewvc/myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java?rev=412381&r1=412380&r2=412381&view=diff
==============================================================================
--- myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java (original)
+++ myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java Wed Jun 7 04:59:21 2006
@@ -206,7 +206,12 @@
FormInfo formInfo = findNestingForm(component, facesContext);
if (formInfo == null)
{
- throw new IllegalArgumentException("Component " + clientId + " must be embedded in an form");
+ String path = RendererUtils.getPathToComponent(component);
+ String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
+ "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
+ " MyFaces core implementation no longer supports formless action sources in order to " +
+ "make your application more inter-operable with the RI. The path to this component is " + path ;
+ throw new IllegalArgumentException(msg);
}
UIComponent nestingForm = formInfo.getForm();
String formName = formInfo.getFormName();
Re: svn commit: r412381 - /myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Posted by Sean Schofield <se...@gmail.com>.
Done. New RC is up as well.
On 6/7/06, Mario Ivankovits <ma...@ops.co.at> wrote:
> Hi Sean,
> > myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
> >
> > - throw new IllegalArgumentException("Component " + clientId + " must be embedded in an form");
> > + String path = RendererUtils.getPathToComponent(component);
> > + String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
> > + "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
> > + " MyFaces core implementation no longer supports formless action sources in order to " +
> > + "make your application more inter-operable with the RI. The path to this component is " + path ;
> >
> I lately changed the message to point to a describing wiki page about
> how to workaround this problem.
> Could you please merge up this change. Its the commit r412108
>
> Thanks!
> Ciao,
> Mario
>
>
Re: svn commit: r412381 - /myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
Posted by Mario Ivankovits <ma...@ops.co.at>.
Hi Sean,
> myfaces/shared/branches/2_0_2/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlLinkRendererBase.java
>
> - throw new IllegalArgumentException("Component " + clientId + " must be embedded in an form");
> + String path = RendererUtils.getPathToComponent(component);
> + String msg = "Change component/tag '" + clientId + "' from javax.faces.*/<h:tagName /> " +
> + "to org.apache.myfaces.*/<t:tagName />, or embed it in a form. This is not a bug. " +
> + " MyFaces core implementation no longer supports formless action sources in order to " +
> + "make your application more inter-operable with the RI. The path to this component is " + path ;
>
I lately changed the message to point to a describing wiki page about
how to workaround this problem.
Could you please merge up this change. Its the commit r412108
Thanks!
Ciao,
Mario