You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2017/09/07 12:21:48 UTC
mesos git commit: Moved duplicate comment closer to implementation.
Repository: mesos
Updated Branches:
refs/heads/master d6c0448dd -> e5778d673
Moved duplicate comment closer to implementation.
Review: https://reviews.apache.org/r/61558/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e5778d67
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e5778d67
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e5778d67
Branch: refs/heads/master
Commit: e5778d6730124890764c33384bd5be631cea9097
Parents: d6c0448
Author: Benno Evers <be...@yandex-team.ru>
Authored: Thu Sep 7 14:21:13 2017 +0200
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Thu Sep 7 14:21:13 2017 +0200
----------------------------------------------------------------------
include/mesos/mesos.proto | 3 ---
include/mesos/v1/mesos.proto | 3 ---
src/master/master.cpp | 2 ++
3 files changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/e5778d67/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 1c74cbb..fa475dc 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -2172,9 +2172,6 @@ message TaskStatus {
// Detailed reason for the task status update.
// Refer to docs/task-state-reasons.md for additional explanation.
- //
- // TODO(bmahler): Differentiate between slave removal reasons
- // (e.g. unhealthy vs. unregistered for maintenance).
enum Reason {
// TODO(jieyu): The default value when a caller doesn't check for
// presence is 0 and so ideally the 0 reason is not a valid one.
http://git-wip-us.apache.org/repos/asf/mesos/blob/e5778d67/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 9aef05f..dfba418 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -2155,9 +2155,6 @@ message TaskStatus {
// Detailed reason for the task status update.
// Refer to docs/task-state-reasons.md for additional explanation.
- //
- // TODO(bmahler): Differentiate between agent removal reasons
- // (e.g. unhealthy vs. unregistered for maintenance).
enum Reason {
// TODO(jieyu): The default value when a caller doesn't check for
// presence is 0 and so ideally the 0 reason is not a valid one.
http://git-wip-us.apache.org/repos/asf/mesos/blob/e5778d67/src/master/master.cpp
----------------------------------------------------------------------
diff --git a/src/master/master.cpp b/src/master/master.cpp
index 14d94cf..53ee87a 100644
--- a/src/master/master.cpp
+++ b/src/master/master.cpp
@@ -8828,6 +8828,8 @@ void Master::_removeSlave(
Framework* framework = getFramework(frameworkId);
foreachvalue (Task* task, utils::copy(slave->tasks[frameworkId])) {
+ // TODO(bmahler): Differentiate between agent removal reasons
+ // (e.g. unhealthy vs. unregistered for maintenance).
const StatusUpdate& update = protobuf::createStatusUpdate(
task->framework_id(),
task->slave_id(),