You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/01/14 14:17:08 UTC
Review Request 65156: Detached the virtual paths regardless of the
result of gc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-8444
https://issues.apache.org/jira/browse/MESOS-8444
Repository: mesos
Description
-------
Detached the virtual paths regardless of the result of gc.
Diffs
-----
src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850
Diff: https://reviews.apache.org/r/65156/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65156: Detached the virtual paths regardless of the
result of gc.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/#review195401
-----------------------------------------------------------
PASS: Mesos patch 65156 was successfully built and tested.
Reviews applied: `['65156']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65156
- Mesos Reviewbot Windows
On Jan. 14, 2018, 2:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65156/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2018, 2:17 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8444
> https://issues.apache.org/jira/browse/MESOS-8444
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Detached the virtual paths regardless of the result of gc.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850
>
>
> Diff: https://reviews.apache.org/r/65156/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65156: Detached the virtual paths regardless of the
result of gc.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 9:37 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Minor change.
Bugs: MESOS-8444
https://issues.apache.org/jira/browse/MESOS-8444
Repository: mesos
Description
-------
Previously we only detach the following paths when the gc for the
executor's sandbox succeeds.
1. /agent_workdir/frameworks/FID/executors/EID/runs/CID
2. /agent_workdir/frameworks/FID/executors/EID/runs/latest
3. /frameworks/FID/executors/EID/runs/latest
But the problem is, such gc may not always succeed, e.g., it may fail
due to the parent directory of the executor's sandbox already gc'ed.
Now in this patch, we will detach those paths regardless of the result
of gc.
Diffs (updated)
-----
src/slave/slave.cpp 5ad6410c06ed7bfdf2e358c2737cfbad3e48df5d
Diff: https://reviews.apache.org/r/65156/diff/3/
Changes: https://reviews.apache.org/r/65156/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65156: Detached the virtual paths regardless of the
result of gc.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/
-----------------------------------------------------------
(Updated Jan. 15, 2018, 9:16 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Updated the description.
Bugs: MESOS-8444
https://issues.apache.org/jira/browse/MESOS-8444
Repository: mesos
Description (updated)
-------
Previously we only detach the following paths when the gc for the
executor's sandbox succeeds.
1. /agent_workdir/frameworks/FID/executors/EID/runs/CID
2. /agent_workdir/frameworks/FID/executors/EID/runs/latest
3. /frameworks/FID/executors/EID/runs/latest
But the problem is, such gc may not always succeed, e.g., it may fail
due to the parent directory of the executor's sandbox already gc'ed.
Now in this patch, we will detach those paths regardless of the result
of gc.
Diffs (updated)
-----
src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850
Diff: https://reviews.apache.org/r/65156/diff/2/
Changes: https://reviews.apache.org/r/65156/diff/1-2/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 65156: Detached the virtual paths regardless of the
result of gc.
Posted by Qian Zhang <zh...@gmail.com>.
> On Jan. 15, 2018, 3:01 a.m., Vinod Kone wrote:
> > Can you expand on the description on why this change is necessary?
Done.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/#review195403
-----------------------------------------------------------
On Jan. 15, 2018, 9:16 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65156/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2018, 9:16 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8444
> https://issues.apache.org/jira/browse/MESOS-8444
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously we only detach the following paths when the gc for the
> executor's sandbox succeeds.
> 1. /agent_workdir/frameworks/FID/executors/EID/runs/CID
> 2. /agent_workdir/frameworks/FID/executors/EID/runs/latest
> 3. /frameworks/FID/executors/EID/runs/latest
>
> But the problem is, such gc may not always succeed, e.g., it may fail
> due to the parent directory of the executor's sandbox already gc'ed.
>
> Now in this patch, we will detach those paths regardless of the result
> of gc.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850
>
>
> Diff: https://reviews.apache.org/r/65156/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65156: Detached the virtual paths regardless of the
result of gc.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65156/#review195403
-----------------------------------------------------------
Ship it!
Can you expand on the description on why this change is necessary?
- Vinod Kone
On Jan. 14, 2018, 2:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65156/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2018, 2:17 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-8444
> https://issues.apache.org/jira/browse/MESOS-8444
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Detached the virtual paths regardless of the result of gc.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850
>
>
> Diff: https://reviews.apache.org/r/65156/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>