[GitHub] EronWright opened a new pull request #7389: [FLINK-11237] [table] Enhance LocalExecutor to wrap TableEnvironment w/ classloader

[GitBox <gi...@apache.org>]

EronWright opened a new pull request #7389: [FLINK-11237] [table] Enhance LocalExecutor to wrap TableEnvironment w/ classloader
URL: https://github.com/apache/flink/pull/7389
 
 
   
   ## What is the purpose of the change
   The `LocalExecutor` calls into the table environment to execute queries, explain statements, and much more. Any call that involves resolving a descriptor to a factory implementation must be wrapped in the context classloader. Some of the calls already are wrapped (for resolving UDFs). With new functionality coming for resolving external catalogs with a descriptor (FLINK-9172), other call sites must be wrapped.
   
   This PR wraps all calls from local executor to table environment, for consistency.   Seems wise to give the table environment maximum flexibility.
   
   ## Brief change log
   
   - use the context classloader for all interactions with TableEnvironment
   
   _Note: based on PR #7388; please ignore changes outside of `LocalExecutor` and `ExecutionContext`._
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `DeploymentTest`, which exercises the `LocalExecutor`'s classloading.  Note that a subsequent PR will enhance `DeploymentTest` for more coverage (FLINK-9172).
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services