[jira] [Comment Edited] (HBASE-19920) TokenUtil.obtainToken unnecessarily creates a local directory

["Francis Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352811#comment-16352811 ] 

Francis Liu edited comment on HBASE-19920 at 2/5/18 7:26 PM:
-------------------------------------------------------------

{quote}That said, clients using ProtobufUtil::toException, ::toComparator, and ::toFilter still might have reason to need the dynamic jars. Not sure how prevalent this is.
{quote}
Took a quick look last week, except for toException All of them are used server-side. And even with toException if it can't instantiate the custom exception it just wraps it in an existing class. So I think even that is acceptable. Because if the user really needed to act on a custom exception it would need to have that class in the classpath.


was (Author: toffer):
{quote}

That said, clients using ProtobufUtil::toException, ::toComparator, and ::toFilter still might have reason to need the dynamic jars. Not sure how prevalent this is.

{quote}

Took a quick look last week, except for toException All of them are used server-side. And even with toException if it can't instantiate the custom exception it just wraps it in an existing class. So I think even that is acceptable. Because if the user really needed to act on a custom exception it would need to have that exception in the classpath.

> TokenUtil.obtainToken unnecessarily creates a local directory
> -------------------------------------------------------------
>
>                 Key: HBASE-19920
>                 URL: https://issues.apache.org/jira/browse/HBASE-19920
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Mike Drob
>            Priority: Major
>             Fix For: 2.0
>
>         Attachments: HBASE-19920.patch
>
>
> On client code, when one calls TokenUtil.obtainToken it loads ProtobufUtil which in its static block initializes DynamicClassLoader and that creates the directory ${hbase.local.dir}/jars/ and also instantiates a filesystem class to access hbase.dynamic.jars.dir.
> https://github.com/apache/hbase/blob/master/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DynamicClassLoader.java#L109-L127
> Since this is region server specific code, not expecting this to happen when one accesses hbase as a client.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)