You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by m4rkmckenna <gi...@git.apache.org> on 2015/11/24 20:58:33 UTC
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
GitHub user m4rkmckenna opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1068
Reverting changes made in #1060 and fixed root cause
I incorrectly diagnosed the issue in #1060 ... so changes made reverted
Root cause was due to Swagger updates made in #1040
`@ApiOperation()` annotation on `CatalogApi#create` had response type set to `javax.ws.rs.core.Response` causing the BrooklynApi to try and marshall the returned entity to that type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/m4rkmckenna/incubator-brooklyn bugfix/brooklyn-api-parse-exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1068
----
commit fd786359a4a2a1468ac9e981cb4a7c1d46803840
Author: Mark McKenna <m4...@gmail.com>
Date: 2015-11-24T19:35:20Z
Reverting incorrect diagnosis for Parse Exception (#1060)
commit ac16772de588a013fb15e077dd685643980125f9
Author: Mark McKenna <m4...@gmail.com>
Date: 2015-11-24T19:40:20Z
Set ApiOperaion response class to String
Reason :: Using javax.ws.rs.core.Response is invalid
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-160087110
@m4rkmckenna passing now, i'll merge it
@Tibor17 there was a period where bugs might get introduced which generate OOME so the GC logging was useful; hasn't been for a while, maybe we should remove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159593160
You have any issue with Surefire output some bug caused by Surefire?
Do you really need -verbose:gc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159545407
rest client tests timed out in jenkins, while tearing down a test i think:
```
TESTNG PASSED: "Surefire test" - org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.testLocationApi() finished in 18 ms
2015-11-24 23:20:02,295 INFO TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterClass org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.tearDown()
Build timed out (after 40 minutes). Marking the build as aborted.
```
smells related. otherwise the work here looks straightforward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159577361
@m4rkmckenna It's unrelated.
My understanding of the issue (https://issues.apache.org/jira/browse/SUREFIRE-859) is that surefire is consuming the output of the test process when it sees unexpected format, caused by verbose garbage collection (configured by us). So it will just print the unrecognized output as is.
The output itself means that the garbage collector has kicked in because of a failure to allocate a buffer, giving some statistics about the gc run.
Just ignore it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159575709
From having run locally I get the below log ... no failure but `GC (Allocation Failure)` is interesting can any one shed any light on this? From what i understand java is trying to allocate memory and failing so GC is kicking in (this may be unrelated)
```
2015-11-25 10:46:45,697 INFO TESTNG PASSED: "Surefire test" - org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.testLocationApi() finished in 8 ms
2015-11-25 10:46:45,698 INFO TESTNG INVOKING CONFIGURATION: "Surefire test" - @AfterClass org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.tearDown()
SUREFIRE-859: [GC (Allocation Failure) 217399K->33627K(753664K), 0.0062667 secs]
SUREFIRE-859: [GC (Allocation Failure) 230235K->45522K(755712K), 0.0161661 secs]
SUREFIRE-859: [GC (Allocation Failure) 255442K->63523K(760320K), 0.0228548 secs]
SUREFIRE-859: [GC (Allocation Failure) 273443K->77064K(726528K), 0.0192347 secs]
SUREFIRE-859: [GC (Allocation Failure) 253192K->88147K(729088K), 0.0135007 secs]
SUREFIRE-859: [GC (Allocation Failure) 264275K->88834K(743424K), 0.0113851 secs]
SUREFIRE-859: [GC (Allocation Failure) 264450K->89195K(742912K), 0.0091640 secs]
2015-11-25 10:46:47,978 INFO TESTNG PASSED CONFIGURATION: "Surefire test" - @AfterClass org.apache.brooklyn.rest.client.BrooklynApiRestClientTest.tearDown() finished in 2281 ms
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159588763
In Surefire 2.19 the prefix "SUREFIRE-859: " was removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Reverting changes made in #1060 a...
Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1068#issuecomment-159589846
Cheers @neykov & @Tibor17
@ahgittin This looks like it was environmental as the previous [build](https://builds.apache.org/job/incubator-brooklyn-pull-requests/2229/) ABORTED also but for a different reason .... how do you want to proceed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---