You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "horizonzy (via GitHub)" <gi...@apache.org> on 2023/03/20 12:40:16 UTC

[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3878: Add V2 protocol support for BenchReadThroughputLatency

horizonzy commented on code in PR #3878:
URL: https://github.com/apache/bookkeeper/pull/3878#discussion_r1142051914


##########
bookkeeper-benchmark/src/main/java/org/apache/bookkeeper/benchmark/BenchReadThroughputLatency.java:
##########
@@ -194,6 +196,10 @@ public static void main(String[] args) throws Exception {
         final ClientConfiguration conf = new ClientConfiguration();
         conf.setReadTimeout(sockTimeout).setZkServers(servers);
 
+        if (cmd.hasOption("useV2")) {

Review Comment:
   cmd.hasOption("useV2") -> cmd.getOptionValue("useV2")



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org