You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 14:27:39 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28767: POC: Remove `@pytest.mark.quarantined` from tests
Taragolis opened a new pull request, #28767:
URL: https://github.com/apache/airflow/pull/28767
closes: #28658
Currently all tests pass either local run or quarantined pipeline in CI. I've just remove flag from all test for check in all possible backends.
Most of the issues in the past related to MySQL 5.7 which almost reach [EOL](https://endoflife.software/applications/databases/mysql), however quarantined pipeline run only with SQLite backend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: POC: Remove `@pytest.mark.quarantined` from tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374412652
Rebased them to re-run and re-check if they are repeatably stable as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: Remove `@pytest.mark.quarantined` from stable quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1376829107
One more rebase just in case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: Remove `@pytest.mark.quarantined` from stable quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1379128861
Let's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374647415
And rebased them with public runners too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374756956
@potiuk I hope it just flaky test and not something wrong with callback mechanism.
Let keep it for a while and have a look how often it failed - just for some statistic, I will exclude this test anyway and try to figure out what the actual nature of this failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1376037991
Yeah, let me revert quarantined mark for this test.
I just think about what we tried to test here:
1. Is on_retry_callback actually called
or
2. Is task retried, e.g. change state to `up_for_retry`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: POC: Remove `@pytest.mark.quarantined` from tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1373718359
Cool. I think we shoudl do it a "bit" gradually (and let them run for a few days after merge). This will be helpful to narrow down the problem in case some of the tests introduce side-effect, to be able to determine which ones it is more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from stable quarantine tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1379104359
@potiuk looks like this tests stable. We would know more about stability after we merge it 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1375630674
And ... this test failed again 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374658509
@Taragolis -> https://github.com/apache/airflow/actions/runs/3864325055/jobs/6587088003 - seems that at least test_process_sigterm_works_with_retries is flaky on public runners ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1374830419
I can't reproduce this error locally but I have an idea what could possible wrong
Potentially callback might acquire lock
https://github.com/apache/airflow/blob/ce677862be4a7de777208ba9ba9e62bcd0415393/tests/jobs/test_local_task_job.py#L779-L784
After it checked in test case
https://github.com/apache/airflow/blob/ce677862be4a7de777208ba9ba9e62bcd0415393/tests/jobs/test_local_task_job.py#L803-L805
However locally I do not have this behaviour. I only could emulate it by adding `time.sleep(5)` before acquire lock in this case time to time test failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28767: Remove `@pytest.mark.quarantined` from remaining quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28767:
URL: https://github.com/apache/airflow/pull/28767#issuecomment-1376006864
Yeah. I think we could merge the others and leave that one as the last - I might also be able to take a look at it shortly (this is kinda what I was expecting and that's why I wanted to do it gradually) :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28767: Remove `@pytest.mark.quarantined` from stable quarantine tests
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28767:
URL: https://github.com/apache/airflow/pull/28767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org