[jira] [Comment Edited] (IMAGING-182) Enhance TIFF writer to support grayscale images

["Gary Lucas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMAGING-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242843#comment-15242843 ] 

Gary Lucas edited comment on IMAGING-182 at 4/15/16 11:40 AM:
--------------------------------------------------------------

I have one already and would be glad to submit it, but I need a little information before I proceed.  The unit test means a modification to the TiffRoundtripTest.java module, which I already changed for Item 170, which has not yet been accepted.  If I add the change for this item, it would conflict with the older patch. So, there are a few ways to proceed: 

 (a) I combine the changes for both items into a single patch (easiest for me, maybe not the best for the project)   
 (b) The decision on whether to accept the 170 changes is deferred or rejected...  I scrap the 170 changes in my version of the code and re-implement the 182 changes on a clean copy of the Apache code...
 (c) The project integrates the 170 changes and I submit a clean patch for 182.

Any of the above are fine with me.

Finally, I note that the GeoTIFF specification permits the storage of data in several different combinations of formats.  Apache Commons Imaging can read almost all of them, but only writes a few. This patch implements just one among many.  So from the perspective of having a "complete implementation of the spec", this change only moves us a little further along.  On the other hand, many of the remaining formats are pretty specialized, and probably not worth the effort.



was (Author: gwlucas):
I have one already and would be glad to submit it, but I need a little information before I proceed.  The unit test means a modification to the TiffRoundtripTest.java module, which I already changed for Item 170.  If I add the change for this item, it would conflict with the older patch. So, there are a few ways to proceed: 

 (a) I combine the changes for both items into a single patch (easiest for me, maybe not the best for the project)   
 (b) The decision on whether to accept the 170 changes is deferred or rejected...  I scrap the 170 changes in my version of the code and re-implement the 182 changes on a clean copy of the Apache code...
 (c) The project integrates the 170 changes and I submit a clean patch for 182.

Any of the above are fine with me.

Finally, I note that the GeoTIFF specification permits the storage of data in several different combinations of formats.  Apache Commons Imaging can read almost all of them, but only writes a few. This patch implements just one among many.  So from the perspective of having a "complete implementation of the spec", this change only moves us a little further along.  On the other hand, many of the remaining formats are pretty specialized, and probably not worth the effort.


> Enhance TIFF writer to support grayscale images
> -----------------------------------------------
>
>                 Key: IMAGING-182
>                 URL: https://issues.apache.org/jira/browse/IMAGING-182
>             Project: Commons Imaging
>          Issue Type: New Feature
>          Components: Format: TIFF
>    Affects Versions: 1.0, 1.x
>            Reporter: Gary Lucas
>         Attachments: Imaging_182_Patch_2016_04_14.patch
>
>
> The current implementation does not permit to storage of grayscale images when writing a TIFF output.  Grayscales come in handy for converting satellite image products to GeoTIFFs for display in GIS applications.  The current implementation can read grayscale formats but cannot writing them.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)