[jira] [Commented] (CB-8307) cordova-windows cert expires in 2015

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287723#comment-14287723 ] 

ASF GitHub Bot commented on CB-8307:
------------------------------------

Github user kirkshoop commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/55#discussion_r23389897
  
    --- Diff: package.json ---
    @@ -26,7 +28,8 @@
         },
         "devDependencies": {
             "jasmine-node": "1.14.5",
    -        "rewire": ">=2.1.3"
    +        "rewire": ">=2.1.3",
    +        "node-forge": "~0.6.18"
    --- End diff --
    
    That is unfortunate. The goal is to only run before publishing a new release. installing from npm is not intended to run this. We really do not want to impose node-forge as a dependency. 
    Do you have a recommendation? Is there any scenario where --production is required to work? If so, perhaps I can check to see if node-forge is installed from the script and skip the certificate creation.


> cordova-windows cert expires in 2015
> ------------------------------------
>
>                 Key: CB-8307
>                 URL: https://issues.apache.org/jira/browse/CB-8307
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 3.5.0, 4.1.3
>            Reporter: Kirk Shoop
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> There is a pfx file checked into the project template that is used to deploy the appx to a device when debugging.
> The pfx file contains a certificate that will expire one year after it was created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org