You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Jacob Wujciak-Jens (Jira)" <ji...@apache.org> on 2022/07/29 11:57:00 UTC
[jira] [Comment Edited] (ARROW-12590) [C++][R] Update copies of Homebrew files to reflect recent updates
[ https://issues.apache.org/jira/browse/ARROW-12590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17572937#comment-17572937 ]
Jacob Wujciak-Jens edited comment on ARROW-12590 at 7/29/22 11:56 AM:
----------------------------------------------------------------------
[~jonkeane] Just so I understand correctly: As far as I see we have added dependencies to our version of the formula that are missing from the upstream version on the other hand the upstream version has update the bottle tag/sha which is likely why we are having issues with that now. So these changes should clearly be synced in both directions.
There are some other changes that should obviously be excluded (download url/version + sha) but also some where I am unsure if we should also sync them down:
- a patch step to change the mimalloc version in versions.txt
- an addition to the test step (running the cpp tests?)
was (Author: JIRAUSER287549):
[~jonkeane] Just so I understand correctly: As far as I see we have added dependencies to our version of the formula that are missing from the upstream version on the other hand the upstream version has update the bottle tag/sha which is likely we are having issues with that now. So these changes should clearly be synced in both directions.
There are some other changes that should obviously be excluded (download url/version + sha) but also some where I am unsure if we should also sync them down:
- a patch step to change the mimalloc version in versions.txt
- an addition to the test step (running the cpp tests?)
> [C++][R] Update copies of Homebrew files to reflect recent updates
> ------------------------------------------------------------------
>
> Key: ARROW-12590
> URL: https://issues.apache.org/jira/browse/ARROW-12590
> Project: Apache Arrow
> Issue Type: Task
> Components: C++, R
> Reporter: Ian Cook
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Our copies of the Homebrew formulae at [https://github.com/apache/arrow/tree/master/dev/tasks/homebrew-formulae] have drifted out of sync with what's currently in [https://github.com/Homebrew/homebrew-core/tree/master/Formula] and [https://github.com/autobrew/homebrew-core/blob/master/Formula|https://github.com/autobrew/homebrew-core/blob/master/Formula/]. Get them back in sync and consider automating some method of checking that they are in sync, e.g. by failing the {{homebrew-cpp}} and
> {{homebrew-r-autobrew}} nightly tests if our copies don't match what's in the Homebrew and autobrew repos (but only if there were changes there that weren't made in our repo, and not the inverse).
> Update the instructions at
> [https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-UpdatingHomebrewpackages] as needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)