[GitHub] [superset] robdiciuccio commented on pull request #13189: build: Ephemeral environments for PRs via slash command

[GitBox <gi...@apache.org>]

robdiciuccio commented on pull request #13189:
URL: https://github.com/apache/superset/pull/13189#issuecomment-781490270


   > Since issue_comment event also has access to all the base repo secrets, would it make sense to bypass the workflow_run step and upload artifacts to ECR in the issue_comment workflow, too?
   
   Ideally, yes, but there's no way (that I've found) for an `issue_comment` event to reference workflow runs for a PR, making it impossible to retrieve the uploaded build artifacts.
   
   > The built docker image is kind of large, too. I'm wondering whether it's possible to use the latest released apache/superset:master as the base image and build a new image just for ECR? (I'd imagine the saved docker build will only contain the new layers with pip package, python file, and static assets overrides.)
   
   Not sure how this would work in a PR context, as the standard docker builds are not pushed to Dockerhub for PRs from forked repos (no secrets access). The current CI (ephemeral env) build is leveraging the cache from the current Docker build process, but agreed that the image size is large. I'm working on getting the overall image size down, but on first pass there's not a whole lot of wasted space here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org