You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/19 08:00:20 UTC
[GitHub] [apisix-dashboard] souzens opened a new issue #831: request help: websocket tab is lost in 2.0rc2？
souzens opened a new issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [yes ] Bug
update to 2.0rc2 . websocket tab is lost in step one。
Has this feature been removed？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-739872457
no plugin need weboscket，which is binding with router
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743976653
https://github.com/apache/apisix/pull/2836/files#diff-ebd29c155b76d68bb1cd728cd626f281f81c62ddb451b345baf2ed8f81480127R378
Hi @membphis, I see there has a tip saying the enable_websocket field will be removed soon, do we have any plan?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-730208372
But note, currently, in plugin page, some of them have UI issues, we are going to resolve all of them in 2.1 soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743987205
no, FE should not use it in upstream
琚致远 <no...@github.com>于2020年12月13日 周日下午6:30写道：
> The frontend will still use that field for now.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA>
> .
>
--
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743718351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743984332
Will be removed in 2.3
琚致远 <no...@github.com>于2020年12月13日 周日下午5:07写道：
>
> https://github.com/apache/apisix/pull/2836/files#diff-ebd29c155b76d68bb1cd728cd626f281f81c62ddb451b345baf2ed8f81480127R378
>
> [image: image]
> <https://user-images.githubusercontent.com/2106987/102007595-7e9ad680-3d65-11eb-8e86-3edb3ccdc2eb.png>
>
> Hi @membphis <https://github.com/membphis>, I see there has a tip saying
> the enable_websocket field will be removed soon, do we have any plan?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743976653>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBK5HYS4RGXHLOZEAEXTSUR73PANCNFSM4T3BLYBA>
> .
>
--
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-744012034
> Conclusion: The frontend will use that field with Route instead of Upstream.
yes, that is right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-730207954
Ya, from 1.5 to 2.0, we have removed some features which originally belong to plugins, you could find them in plugin page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743987363
Websocket is binding with route now
Ming Wen <mo...@gmail.com>于2020年12月13日 周日下午6:47写道：
> no, FE should not use it in upstream
>
> 琚致远 <no...@github.com>于2020年12月13日 周日下午6:30写道：
>
>> The frontend will still use that field for now.
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA>
>> .
>>
> --
> Thanks,
> Ming Wen
> Twitter: _WenMing
>
--
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-732595015
according to current tasks, this enhancement feature will resolve in 2.3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985039
I couldn't find milestone 2.3, you mean 3.0 or 2.3 has not been created?
https://github.com/apache/apisix/milestones
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743715300
in `Route`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-740218196
I see, i will check this ASAP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iyuhptop commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
iyuhptop commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-739755674
which plugin should select for websocket
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743990396
> Websocket is binding with route now
>
> Ming Wen <mo...@gmail.com>于2020年12月13日 周日下午6:47写道：
>
> > no, FE should not use it in upstream
> >
> > 琚致远 <no...@github.com>于2020年12月13日 周日下午6:30写道：
> >
> >> The frontend will still use that field for now.
> >>
> >> —
> >> You are receiving this because you commented.
> >> Reply to this email directly, view it on GitHub
> >> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080>,
> >> or unsubscribe
> >> <https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA>
> >> .
> >>
> > --
> > Thanks,
> > Ming Wen
> > Twitter: _WenMing
> >
> --
> Thanks,
> Ming Wen
> Twitter: _WenMing
>
Ok, now i know what happened, i heard from @membphis that this field is bound to Route and called enable_websocket, but when i saw that PR, i didn't see that change is related to upstream_def until you point out.
Conclusion: The frontend will use that field with Route instead of Upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080
The frontend will still use that field for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #831: request help: websocket tab is lost in 2.0rc2？
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #831:
URL: https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743987816
Please check the Chang log of apisix for detail
Ming Wen <mo...@gmail.com>于2020年12月13日 周日下午6:48写道：
> Websocket is binding with route now
>
> Ming Wen <mo...@gmail.com>于2020年12月13日 周日下午6:47写道：
>
>> no, FE should not use it in upstream
>>
>> 琚致远 <no...@github.com>于2020年12月13日 周日下午6:30写道：
>>
>>> The frontend will still use that field for now.
>>>
>>> —
>>> You are receiving this because you commented.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/apisix-dashboard/issues/831#issuecomment-743985080>,
>>> or unsubscribe
>>> <https://github.com/notifications/unsubscribe-auth/AGJZBK7BI4YGKBU36LZLCL3SUSJTVANCNFSM4T3BLYBA>
>>> .
>>>
>> --
>> Thanks,
>> Ming Wen
>> Twitter: _WenMing
>>
> --
> Thanks,
> Ming Wen
> Twitter: _WenMing
>
--
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org