You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2021/01/28 12:29:00 UTC

[jira] [Commented] (TEZ-4236) DAGClientServer is not really needed to be started/used in local mode

    [ https://issues.apache.org/jira/browse/TEZ-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273532#comment-17273532 ] 

Hadoop QA commented on TEZ-4236:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 36s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m  0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 42s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 15s{color} | {color:green} tez-api: The patch generated 0 new + 152 unchanged - 2 fixed = 152 total (was 154) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 18s{color} | {color:orange} tez-dag: The patch generated 1 new + 113 unchanged - 0 fixed = 114 total (was 113) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color} | {color:green} The patch passed checkstyle in tez-tests {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 46s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  4m  8s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 44m 47s{color} | {color:green} tez-tests in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 30s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 17s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.TestSpeculation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/99/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4236 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13019559/TEZ-4236.06.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 001ce9be4887 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 033ba9160 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| checkstyle | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/99/artifact/out/diff-checkstyle-tez-dag.txt |
| unit | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/99/artifact/out/patch-unit-tez-dag.txt |
|  Test Results | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/99/testReport/ |
| Max. process+thread count | 1299 (vs. ulimit of 5500) |
| modules | C: tez-api tez-dag tez-tests U: . |
| Console output | https://ci-hadoop.apache.org/job/PreCommit-TEZ-Build/99/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> DAGClientServer is not really needed to be started/used in local mode
> ---------------------------------------------------------------------
>
>                 Key: TEZ-4236
>                 URL: https://issues.apache.org/jira/browse/TEZ-4236
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4236.01.patch, TEZ-4236.02.patch, TEZ-4236.03.patch, TEZ-4236.04.patch, TEZ-4236.05.patch, TEZ-4236.06.patch
>
>
> For a customer, we found that they try to run hive on tez local mode tests, and due to strict firewall rules and security policy, the DagClientServer struggles to start or respond to connections (think about corporate laptops here). Instead of investigating the network-related workarounds, let's find another way and decide if DAGAppMaster really needs this server. 
> LocalClient has an embedded [DAGAppMaster|https://github.com/apache/tez/blob/master/tez-dag/src/main/java/org/apache/tez/client/LocalClient.java#L65], so at the first sight, it doesn't make sense to rely on the network environment in terms of AM usage. Hopefully, AM can become more lightweight in the long term if we try to eliminate pointless network usage. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)