You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhan Reddy <mr...@gmail.com> on 2017/04/11 10:10:18 UTC

Review Request 58341: Issue while adding custom job.properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58341/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.


Bugs: AMBARI-20705
    https://issues.apache.org/jira/browse/AMBARI-20705


Repository: ambari


Description
-------

Added the custom properties if it is present even without clicking '+'


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js efe8385 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs e3d49ec 


Diff: https://reviews.apache.org/r/58341/diff/1/


Testing
-------

Manual


Thanks,

Madhan Reddy


Re: Review Request 58341: Issue while adding custom job.properties

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58341/#review171548
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On April 11, 2017, 10:10 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58341/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20705
>     https://issues.apache.org/jira/browse/AMBARI-20705
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added the custom properties if it is present even without clicking '+'
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js efe8385 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs e3d49ec 
> 
> 
> Diff: https://reviews.apache.org/r/58341/diff/1/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>


Re: Review Request 58341: Issue while adding custom job.properties

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58341/#review171549
-----------------------------------------------------------


Ship it!




Ship It!

- Padma Priya N


On April 11, 2017, 10:10 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58341/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20705
>     https://issues.apache.org/jira/browse/AMBARI-20705
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added the custom properties if it is present even without clicking '+'
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js efe8385 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs e3d49ec 
> 
> 
> Diff: https://reviews.apache.org/r/58341/diff/1/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>