You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/11 07:26:03 UTC

[GitHub] [incubator-nuttx] no1wudi commented on a diff in pull request #6596: vncserver enhancement

no1wudi commented on code in PR #6596:
URL: https://github.com/apache/incubator-nuttx/pull/6596#discussion_r917618692


##########
drivers/video/vnc/vnc_fbdev.c:
##########
@@ -577,6 +577,64 @@ static inline int vnc_wait_start(int display)
   return OK;
 }
 
+/****************************************************************************
+ * Name: vnc_session_alloc
+ *
+ * Description:
+ *   Alloc vnc session and init essential member of it.
+ *
+ ****************************************************************************/
+
+static int vnc_session_alloc(void)
+{
+  FAR struct vnc_session_s *session;
+  int display;
+  int ret = OK;
+  FAR uint8_t *fb;
+
+  for (display = 0; display < RFB_MAX_DISPLAYS; display++)

Review Comment:
   Touch/kbd inited before start vnc_server thread, thus the `g_vnc_sessions` is NULL before `vnc_start_server`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org