You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Kevin Lu <lu...@berkeley.edu> on 2018/07/25 16:05:53 UTC

[VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

Hi All,

I am calling a vote for KIP-344
https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter
.

If any committer feels that this minor change does not need to go through
the KIP process, then feel free to leave a code review at
https://github.com/apache/kafka/pull/5383 and I will cancel the KIP.

Regards,
Kevin

Re: [VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

Posted by Kevin Lu <lu...@berkeley.edu>.

Hi All,

Forgot to post this earlier, but I cancelled this KIP as we determined this
is a bug fix.

Could a committer review/merge the PR (
https://github.com/apache/kafka/pull/5383)?

Colin has already finished and approved a review.

Thanks!

Regards,
Kevin

On Wed, Jul 25, 2018 at 10:12 AM Ted Yu <yu...@gmail.com> wrote:

> +1
>
> On Wed, Jul 25, 2018 at 9:49 AM Kevin Lu <lu...@berkeley.edu> wrote:
>
> > Hi All,
> >
> > I am calling a vote for KIP-344
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter
> > .
> >
> > If any committer feels that this minor change does not need to go through
> > the KIP process, then feel free to leave a code review at
> > https://github.com/apache/kafka/pull/5383 and I will cancel the KIP.
> >
> > Regards,
> > Kevin
> >
>

Re: [VOTE] KIP-344: The auto-generated client id should be passed to MetricsReporter

Posted by Ted Yu <yu...@gmail.com>.

+1

On Wed, Jul 25, 2018 at 9:49 AM Kevin Lu <lu...@berkeley.edu> wrote:

> Hi All,
>
> I am calling a vote for KIP-344
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-344%3A+The+auto-generated+client+id+should+be+passed+to+MetricsReporter
> .
>
> If any committer feels that this minor change does not need to go through
> the KIP process, then feel free to leave a code review at
> https://github.com/apache/kafka/pull/5383 and I will cancel the KIP.
>
> Regards,
> Kevin
>