You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2023/03/27 06:23:12 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #40557: [SPARK-42928][SQL] Make resolvePersistentFunction synchronized
cloud-fan commented on code in PR #40557:
URL: https://github.com/apache/spark/pull/40557#discussion_r1148833316
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -1719,7 +1719,8 @@ class SessionCatalog(
name: FunctionIdentifier,
arguments: Seq[Expression],
registry: FunctionRegistryBase[T],
- createFunctionBuilder: CatalogFunction => FunctionRegistryBase[T]#FunctionBuilder): T = {
+ createFunctionBuilder: CatalogFunction => FunctionRegistryBase[T]#FunctionBuilder
+ ): T = synchronized {
Review Comment:
which part is not thread-safe? `qualifyIdentifier`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org