You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/06/17 01:06:51 UTC
svn commit: r1493605 - in
/tomcat/trunk/java/org/apache/tomcat/websocket/pojo:
PojoMessageHandlerPartialBase.java PojoMessageHandlerWholeBase.java
Author: markt
Date: Sun Jun 16 23:06:51 2013
New Revision: 1493605
URL: http://svn.apache.org/r1493605
Log:
Fix FindBugs warnings. params is never null so no need to test for null
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java?rev=1493605&r1=1493604&r2=1493605&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java Sun Jun 16 23:06:51 2013
@@ -48,8 +48,7 @@ public abstract class PojoMessageHandler
@Override
public final void onMessage(T message, boolean last) {
- if (params != null && params.length == 1 &&
- params[0] instanceof DecodeException) {
+ if (params.length == 1 && params[0] instanceof DecodeException) {
((WsSession) session).getLocal().onError(session,
(DecodeException) params[0]);
return;
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java?rev=1493605&r1=1493604&r2=1493605&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java Sun Jun 16 23:06:51 2013
@@ -45,8 +45,7 @@ public abstract class PojoMessageHandler
@Override
public final void onMessage(T message) {
- if (params != null && params.length == 1 &&
- params[0] instanceof DecodeException) {
+ if (params.length == 1 && params[0] instanceof DecodeException) {
((WsSession) session).getLocal().onError(session,
(DecodeException) params[0]);
return;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org