You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/07/27 14:49:46 UTC
Review Request 61180: Added a resource providers total resources to
the subscribe call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-7837
https://issues.apache.org/jira/browse/MESOS-7837
Repository: mesos
Description
-------
Since resource provider resources are dynamic (as opposed to how e.g.,
agent total resources are implemented), they are not part of the
'ResourceProviderInfo'. Instead they are communicated explicitly.
This commit adds total resources the resource provider 'SUBSCRIBE'
call which can be used to communicate the total capacity in both
subscription and resubscription scenarios.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
Diff: https://reviews.apache.org/r/61180/diff/1/
Testing
-------
Tested as part of https://reviews.apache.org/r/61182/.
Thanks,
Benjamin Bannier
Re: Review Request 61180: Added a resource providers total resources
to the subscribe call.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/#review181732
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On July 27, 2017, 2:49 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61180/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 2:49 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since resource provider resources are dynamic (as opposed to how e.g.,
> agent total resources are implemented), they are not part of the
> 'ResourceProviderInfo'. Instead they are communicated explicitly.
>
> This commit adds total resources the resource provider 'SUBSCRIBE'
> call which can be used to communicate the total capacity in both
> subscription and resubscription scenarios.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
> include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
>
>
> Diff: https://reviews.apache.org/r/61180/diff/1/
>
>
> Testing
> -------
>
> Tested as part of https://reviews.apache.org/r/61182/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61180: Added a resource providers total resources
to the subscribe call.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/#review182383
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Aug. 1, 2017, 7:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61180/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2017, 7:42 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since resource provider resources are dynamic (as opposed to how e.g.,
> agent total resources are implemented), they are not part of the
> 'ResourceProviderInfo'. Instead they are communicated explicitly.
>
> This commit adds total resources the resource provider 'SUBSCRIBE'
> call which can be used to communicate the total capacity in both
> subscription and resubscription scenarios.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
> include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
>
>
> Diff: https://reviews.apache.org/r/61180/diff/3/
>
>
> Testing
> -------
>
> Tested as part of https://reviews.apache.org/r/61182/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61180: Added a resource providers total resources
to the subscribe call.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/
-----------------------------------------------------------
(Updated Aug. 1, 2017, 7:42 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-7837
https://issues.apache.org/jira/browse/MESOS-7837
Repository: mesos
Description
-------
Since resource provider resources are dynamic (as opposed to how e.g.,
agent total resources are implemented), they are not part of the
'ResourceProviderInfo'. Instead they are communicated explicitly.
This commit adds total resources the resource provider 'SUBSCRIBE'
call which can be used to communicate the total capacity in both
subscription and resubscription scenarios.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
Diff: https://reviews.apache.org/r/61180/diff/3/
Changes: https://reviews.apache.org/r/61180/diff/2-3/
Testing
-------
Tested as part of https://reviews.apache.org/r/61182/.
Thanks,
Benjamin Bannier
Re: Review Request 61180: Added a resource providers total resources
to the subscribe call.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/#review181845
-----------------------------------------------------------
Ship it!
include/mesos/v1/resource_provider/resource_provider.proto
Lines 72 (patched)
<https://reviews.apache.org/r/61180/#comment257613>
You should add a TODO here as well.
- Jie Yu
On July 31, 2017, 3:08 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61180/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 3:08 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-7837
> https://issues.apache.org/jira/browse/MESOS-7837
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since resource provider resources are dynamic (as opposed to how e.g.,
> agent total resources are implemented), they are not part of the
> 'ResourceProviderInfo'. Instead they are communicated explicitly.
>
> This commit adds total resources the resource provider 'SUBSCRIBE'
> call which can be used to communicate the total capacity in both
> subscription and resubscription scenarios.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
> include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
>
>
> Diff: https://reviews.apache.org/r/61180/diff/2/
>
>
> Testing
> -------
>
> Tested as part of https://reviews.apache.org/r/61182/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 61180: Added a resource providers total resources
to the subscribe call.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61180/
-----------------------------------------------------------
(Updated July 31, 2017, 5:08 p.m.)
Review request for mesos, Jie Yu and Jan Schlicht.
Changes
-------
Added a `TODO`.
Bugs: MESOS-7837
https://issues.apache.org/jira/browse/MESOS-7837
Repository: mesos
Description
-------
Since resource provider resources are dynamic (as opposed to how e.g.,
agent total resources are implemented), they are not part of the
'ResourceProviderInfo'. Instead they are communicated explicitly.
This commit adds total resources the resource provider 'SUBSCRIBE'
call which can be used to communicate the total capacity in both
subscription and resubscription scenarios.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto a8a27ed09cde7a9f137e76900a3a1c1a547752ed
include/mesos/v1/resource_provider/resource_provider.proto 34bce7511bc74e157277371a7f46111c9537bcf2
Diff: https://reviews.apache.org/r/61180/diff/2/
Changes: https://reviews.apache.org/r/61180/diff/1-2/
Testing
-------
Tested as part of https://reviews.apache.org/r/61182/.
Thanks,
Benjamin Bannier