You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by norrs <gi...@git.apache.org> on 2017/07/26 19:13:22 UTC
[GitHub] thrift pull request #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
GitHub user norrs opened a pull request:
https://github.com/apache/thrift/pull/1315
THRIFT-4264: Fix PHP tests requiring sockets.so
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Patch: Håkon Hitland <ha...@zedge.net>
This closes #4264
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/norrs/thrift THRIFT-4264
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1315
----
commit 65257ae869cdc218b49125e5a01ec1d8fa2fab13
Author: Håkon Hitland <ha...@zedge.net>
Date: 2017-07-25T14:38:26Z
THRIFT-4264: Fix PHP tests requiring sockets.so
The PHP library requires sockets.so for the socket_import_stream() function.
Make it available for the tests by symlinking in the module.
Patch: Håkon Hitland <ha...@zedge.net>
This closes #4264
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1315
---
[GitHub] thrift issue #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by norrs <gi...@git.apache.org>.
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
Test failures seems unrelated, how do we retrigger em to be run again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by norrs <gi...@git.apache.org>.
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
@jeking3 : Done; let's see how it goes this time.
---
[GitHub] thrift issue #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by norrs <gi...@git.apache.org>.
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
Rebased on top of master to trigger tests to be run again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by norrs <gi...@git.apache.org>.
Github user norrs commented on the issue:
https://github.com/apache/thrift/pull/1315
https://issues.apache.org/jira/browse/THRIFT-4264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1315: THRIFT-4264: Fix PHP tests requiring sockets.so
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1315
@norrs now that the CI builds have been stabilized, if you could rebase on master and refresh this PR, we'll try to get a clean build out of it.
---