You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2025/10/13 06:47:23 UTC
[PR] [fix](editlog) do not write editlog if not master [doris]
dataroaring opened a new pull request, #56896:
URL: https://github.com/apache/doris/pull/56896
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3402007371
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/57)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56896_652ff20c8130eb26cb4ab1f7355ab1130f0f516b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56896_652ff20c8130eb26cb4ab1f7355ab1130f0f516b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3400718052
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #56896:
URL: https://github.com/apache/doris/pull/56896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3404273845
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3396078607
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3404273901
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3400864790
<details>
<summary>TPC-DS: <b>Total hot run time: 190796 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 652ff20c8130eb26cb4ab1f7355ab1130f0f516b, data reload: false
query1 1066 436 412 412
query2 6581 1683 1698 1683
query3 6758 225 218 218
query4 26704 23781 23747 23747
query5 4842 656 495 495
query6 340 261 230 230
query7 4661 499 318 318
query8 316 272 261 261
query9 8741 2568 2588 2568
query10 515 341 292 292
query11 15809 15095 14825 14825
query12 190 117 113 113
query13 1667 570 434 434
query14 11792 9129 9295 9129
query15 208 188 173 173
query16 7676 689 475 475
query17 1316 751 624 624
query18 2184 472 365 365
query19 239 218 181 181
query20 157 141 139 139
query21 221 142 133 133
query22 4797 4903 4818 4818
query23 34724 34335 33583 33583
query24 8390 2481 2533 2481
query25 617 531 498 498
query26 1458 279 197 197
query27 2898 523 427 427
query28 5619 2211 2215 2211
query29 790 637 527 527
query30 315 250 215 215
query31 940 840 741 741
query32 87 89 81 81
query33 599 375 335 335
query34 829 890 551 551
query35 812 837 765 765
query36 1003 1008 896 896
query37 115 114 88 88
query38 3513 3491 3501 3491
query39 1482 1433 1407 1407
query40 225 126 117 117
query41 62 57 59 57
query42 121 107 106 106
query43 479 498 463 463
query44 1334 835 825 825
query45 181 180 179 179
query46 835 987 629 629
query47 1804 1852 1757 1757
query48 405 426 314 314
query49 764 519 433 433
query50 646 694 407 407
query51 3936 3938 3836 3836
query52 111 106 99 99
query53 240 271 190 190
query54 586 591 524 524
query55 94 86 85 85
query56 319 311 305 305
query57 1211 1210 1143 1143
query58 288 298 302 298
query59 2608 2626 2541 2541
query60 346 345 341 341
query61 159 150 145 145
query62 802 722 672 672
query63 231 195 192 192
query64 4406 1187 850 850
query65 4082 3970 3992 3970
query66 1085 435 332 332
query67 15812 15181 15152 15152
query68 7937 934 608 608
query69 496 324 299 299
query70 1415 1302 1306 1302
query71 467 350 322 322
query72 5996 5116 4932 4932
query73 626 568 361 361
query74 8868 9159 8921 8921
query75 3531 3335 2822 2822
query76 3375 1213 729 729
query77 598 421 317 317
query78 9479 9757 8940 8940
query79 3474 834 590 590
query80 718 557 487 487
query81 502 260 230 230
query82 467 157 131 131
query83 301 273 247 247
query84 309 121 97 97
query85 1029 475 455 455
query86 337 325 297 297
query87 3765 3802 3664 3664
query88 3071 2262 2263 2262
query89 459 339 313 313
query90 2019 224 221 221
query91 163 169 135 135
query92 80 71 62 62
query93 2151 978 648 648
query94 747 454 324 324
query95 403 317 318 317
query96 485 579 288 288
query97 2970 2963 2869 2869
query98 241 217 211 211
query99 1441 1412 1306 1306
Total cold run time: 282063 ms
Total hot run time: 190796 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3400891048
<details>
<summary>ClickBench: <b>Total hot run time: 29.97 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 652ff20c8130eb26cb4ab1f7355ab1130f0f516b, data reload: false
query1 0.05 0.04 0.05
query2 0.09 0.05 0.06
query3 0.26 0.09 0.09
query4 1.60 0.11 0.12
query5 0.30 0.27 0.25
query6 1.15 0.66 0.65
query7 0.03 0.02 0.02
query8 0.06 0.04 0.04
query9 0.62 0.54 0.52
query10 0.58 0.57 0.58
query11 0.20 0.11 0.12
query12 0.15 0.12 0.12
query13 0.63 0.61 0.62
query14 1.05 1.05 1.03
query15 0.88 0.85 0.86
query16 0.42 0.41 0.39
query17 1.05 1.02 1.05
query18 0.21 0.20 0.19
query19 1.93 1.85 1.90
query20 0.02 0.01 0.01
query21 15.46 0.92 0.59
query22 0.77 1.18 0.67
query23 14.97 1.38 0.64
query24 7.69 1.62 0.40
query25 0.29 0.17 0.08
query26 0.63 0.16 0.13
query27 0.09 0.06 0.06
query28 9.44 1.36 0.92
query29 12.58 4.02 3.27
query30 0.28 0.13 0.12
query31 2.83 0.58 0.38
query32 3.26 0.58 0.48
query33 3.05 3.14 3.06
query34 16.11 5.42 4.86
query35 4.90 4.94 4.90
query36 0.68 0.51 0.50
query37 0.10 0.08 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.15
query41 0.09 0.03 0.03
query42 0.04 0.04 0.03
query43 0.05 0.04 0.04
Total cold run time: 104.88 s
Total hot run time: 29.97 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3401757803
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/57)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56896_652ff20c8130eb26cb4ab1f7355ab1130f0f516b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56896_652ff20c8130eb26cb4ab1f7355ab1130f0f516b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](editlog) do not write editlog if not master [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #56896:
URL: https://github.com/apache/doris/pull/56896#issuecomment-3396084749
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org