[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #474: [Improvement] Remove some unused empty server metrics

[GitBox <gi...@apache.org>]

advancedxy commented on code in PR #474:
URL: https://github.com/apache/incubator-uniffle/pull/474#discussion_r1068008972


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerMetrics.java:
##########
@@ -250,8 +244,6 @@ private static void setUpMetrics() {
     counterTotalReadLocalIndexFileSize = metricsManager.addCounter(TOTAL_READ_LOCAL_INDEX_FILE);
     counterTotalReadMemoryDataSize = metricsManager.addCounter(TOTAL_READ_MEMORY_DATA);
     counterTotalReadTime = metricsManager.addCounter(TOTAL_READ_TIME);
-    counterTotalUploadSize = metricsManager.addCounter(TOTAL_UPLOAD_SIZE);

Review Comment:
   why the field `TOTAL_UPLOAD_SIZE` and related ones are not removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org