You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2016/12/15 15:33:15 UTC
[GitHub] qpid-dispatch pull request #127: DISPATCH-596 - Preserve the error from the ...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/127
DISPATCH-596 - Preserve the error from the rejected state in relayed \u2026
\u2026disposition
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-596
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 01461e4ebb4b40fe3862a528e5b77493128ad315
Author: Ganesh Murthy <gm...@redhat.com>
Date: 2016-12-15T15:29:44Z
DISPATCH-596 - Preserve the error from the rejected state in relayed disposition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #127: DISPATCH-596 - Preserve the error from the ...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/127#discussion_r93043324
--- Diff: src/router_node.c ---
@@ -947,6 +964,9 @@ static void CORE_delivery_update(void *context, qdr_delivery_t *dlv, uint64_t di
pn_delivery_settle(pnd);
qdr_delivery_decref(dlv);
}
+
+ if (error)
--- End diff --
When you free the error record here, the pointer (now invalid) remains in the delivery record. It could be referenced and possibly re-freed in the future. I think the error record should be freed when the delivery record is freed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #127: DISPATCH-596 - Preserve the error from the ...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org