You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/22 03:05:46 UTC
[GitHub] [flink] zjffdu opened a new pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
zjffdu opened a new pull request #12288:
URL: https://github.com/apache/flink/pull/12288
## What is the purpose of the change
`executeAsync` doesn't add dependent jars which cause ClassNotFound issue. This PR does some refactoring and add dependent jars for both `execute` and `executeAsync`
## Verifying this change
Manually tested vis scala-shell
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u closed pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #12288:
URL: https://github.com/apache/flink/pull/12288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #12288:
URL: https://github.com/apache/flink/pull/12288#discussion_r429818998
##########
File path: flink-scala-shell/src/main/java/org/apache/flink/api/java/ScalaShellEnvironment.java
##########
@@ -70,15 +71,12 @@ private static Configuration validateAndGetConfiguration(final Configuration con
return checkNotNull(configuration);
}
- @Override
- public JobExecutionResult execute(String jobName) throws Exception {
Review comment:
Same as below. This would become:
```
@Override
public JobClient executeAsync(String jobName) throws Exception {
final Configuration configuration = getConfiguration();
checkState(configuration.getBoolean(DeploymentOptions.ATTACHED), "Only ATTACHED mode is supported by the scala shell.");
final List<URL> updatedJarFiles = getUpdatedJarFiles();
ConfigUtils.encodeCollectionToConfig(configuration, PipelineOptions.JARS, updatedJarFiles, URL::toString);
return super.executeAsync(jobName);
}
```
##########
File path: flink-scala-shell/src/main/java/org/apache/flink/api/java/ScalaShellStreamEnvironment.java
##########
@@ -71,19 +72,40 @@ private static Configuration validateAndGetConfiguration(final Configuration con
@Override
public JobExecutionResult execute(StreamGraph streamGraph) throws Exception {
Review comment:
Wouldn't just overriding the `executeAsync` instead of the `execute` work? So this would become:
```
@Override
public JobClient executeAsync(StreamGraph streamGraph) throws Exception {
final Configuration configuration = getConfiguration();
checkState(configuration.getBoolean(DeploymentOptions.ATTACHED), "Only ATTACHED mode is supported by the scala shell.");
final List<URL> updatedJarFiles = getUpdatedJarFiles();
ConfigUtils.encodeCollectionToConfig(configuration, PipelineOptions.JARS, updatedJarFiles, URL::toString);
return super.executeAsync(streamGraph);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632453444
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 (Fri May 22 03:08:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17870).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
}, {
"hash" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2133",
"triggerID" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026)
* ac2c0b9608fcd8c88d215e4522ec4842102e22c6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2133)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632453444
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ac2c0b9608fcd8c88d215e4522ec4842102e22c6 (Fri Oct 16 10:54:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjffdu commented on a change in pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #12288:
URL: https://github.com/apache/flink/pull/12288#discussion_r429830761
##########
File path: flink-scala-shell/src/main/java/org/apache/flink/api/java/ScalaShellStreamEnvironment.java
##########
@@ -71,19 +72,40 @@ private static Configuration validateAndGetConfiguration(final Configuration con
@Override
public JobExecutionResult execute(StreamGraph streamGraph) throws Exception {
Review comment:
Thanks for the review, @kl0u You are right, let me update this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
}, {
"hash" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08bc3bf4a17f2e6a99ce5ff3af91ae1341254391 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026)
* ac2c0b9608fcd8c88d215e4522ec4842102e22c6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-633341329
@aljoscha @kl0u Could you help review it ? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-632456377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2026",
"triggerID" : "08bc3bf4a17f2e6a99ce5ff3af91ae1341254391",
"triggerType" : "PUSH"
}, {
"hash" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2133",
"triggerID" : "ac2c0b9608fcd8c88d215e4522ec4842102e22c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac2c0b9608fcd8c88d215e4522ec4842102e22c6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2133)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zjffdu commented on pull request #12288: [FLINK-17870]. dependent jars are missing to be shipped to cluster in scala shell
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #12288:
URL: https://github.com/apache/flink/pull/12288#issuecomment-633479667
@kl0u I have updated this PR, could you help review it ? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org