You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/11/09 17:18:24 UTC
[PR] make r2dbc-postgresql dependency 'provided' [pekko-persistence-r2dbc]
pjfanning opened a new pull request, #173:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/173
* relates to #170
* idea is that it should be ok in a minor release like 1.1.0 to change the r2dbc-postgresql dependency to provided
* if we add support for another db product then its r2dbc jar would also be 'provided'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make r2dbc-postgresql dependency 'provided' [pekko-persistence-r2dbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #173:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/173#discussion_r1847585489
##########
project/Dependencies.scala:
##########
@@ -34,8 +34,7 @@ object Dependencies {
val r2dbcSpi = "io.r2dbc" % "r2dbc-spi" % "1.0.0.RELEASE"
val r2dbcPool = "io.r2dbc" % "r2dbc-pool" % "1.0.2.RELEASE"
- val r2dbcPostgres = Seq(
- "org.postgresql" % "r2dbc-postgresql" % "1.0.7.RELEASE")
+ val r2dbcPostgres = "org.postgresql" % "r2dbc-postgresql" % "1.0.7.RELEASE"
Review Comment:
This is ok, but better we later includes it in release note too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make r2dbc-postgresql dependency 'provided' [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #173:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/173#discussion_r1847938261
##########
project/Dependencies.scala:
##########
@@ -34,8 +34,7 @@ object Dependencies {
val r2dbcSpi = "io.r2dbc" % "r2dbc-spi" % "1.0.0.RELEASE"
val r2dbcPool = "io.r2dbc" % "r2dbc-pool" % "1.0.2.RELEASE"
- val r2dbcPostgres = Seq(
- "org.postgresql" % "r2dbc-postgresql" % "1.0.7.RELEASE")
+ val r2dbcPostgres = "org.postgresql" % "r2dbc-postgresql" % "1.0.7.RELEASE"
Review Comment:
yes - this will definitely be in the release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] make r2dbc-postgresql dependency 'provided' [pekko-persistence-r2dbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #173:
URL: https://github.com/apache/pekko-persistence-r2dbc/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org