[GitHub] [inlong] Oneal65 opened a new pull request, #5140: [Feature][Sort] Import all changelog mode data ingest into kafka

[GitBox <gi...@apache.org>]

Oneal65 opened a new pull request, #5140:
URL: https://github.com/apache/inlong/pull/5140

   
   - Fixes #5119 
   
   ### Motivation
   
   kafka does not support CDC sink, so we could give a option to regard all changelog data as insert-only data. So we can insert into kafka from canal-json，rowkind as a kafka schema field.
   
   ### Modifications
   
   add a canal json option to support insert-only mode
   
   ### Verifying this change
   
   *(Please pick either of the following options)*
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [ ] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
     *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5140: [INLONG-5119][Sort] Import all changelog mode data ingest into Kafka

[GitBox <gi...@apache.org>]

healchow merged PR #5140:
URL: https://github.com/apache/inlong/pull/5140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5140: [INLONG-5119][Sort] Import all changelog mode data ingest into Kafka

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #5140:
URL: https://github.com/apache/inlong/pull/5140#discussion_r926361399


##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/KafkaDynamicTableFactory.java:
##########
@@ -60,32 +59,32 @@
 import java.util.Set;
 import java.util.regex.Pattern;
 
-import static org.apache.flink.streaming.connectors.kafka.table.KafkaOptions.KEY_FIELDS;

Review Comment:
   It is better not to change this reference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org