You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/29 03:25:45 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7091: [Issue 7049][WebSokcet] Make WebSocketService.MaxTextFrameSize configurable

codelipenghui commented on a change in pull request #7091:
URL: https://github.com/apache/pulsar/pull/7091#discussion_r432218399



##########
File path: pulsar-websocket/src/main/java/org/apache/pulsar/websocket/service/WebSocketProxyConfiguration.java
##########
@@ -66,6 +66,8 @@
     private Optional<Integer> webServicePortTls = Optional.empty();
     // Hostname or IP address the service binds on, default is 0.0.0.0.
     private String bindAddress;
+    // The maximum size of a text message during parsing in WebSocket proxy
+    private int webSocketMaxTextFrameSize = 1024 * 1024;

Review comment:
       It's better to use 5MB as default value since the max message size of the broker is 5MB.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org