[jira] [Commented] (TS-4408) volume.config is ordering sensitive

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273212#comment-15273212 ] 

ASF GitHub Bot commented on TS-4408:
------------------------------------

GitHub user calavera opened a pull request:

    https://github.com/apache/trafficserver/pull/618

    [TS-4408] Make volume.config not order sensitive.

    I added a couple of additional checks:
    
    1. Fail with a format error if there are duplicated tokens, for instance:
    
    	volume=1 size=50% size=25%
    
    2. Ignore everything else if there are other unknown tokens after parsing size and scheme:
    
    	volume=1 size=50% scheme=https foo=bar
    
    Please, let me know if this is correct.
    
    Signed-off-by: David Calavera <da...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/calavera/trafficserver volume_tokens

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #618
    
----
commit 4a0727ac0195f0a0e449de0e96bf3d1efdf26c19
Author: David Calavera <da...@gmail.com>
Date:   2016-05-05T22:09:20Z

    [TS-4408] Make volume.config not order sensitive.
    
    Signed-off-by: David Calavera <da...@gmail.com>

----


> volume.config is ordering sensitive
> -----------------------------------
>
>                 Key: TS-4408
>                 URL: https://issues.apache.org/jira/browse/TS-4408
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: James Peach
>             Fix For: sometime
>
>
> {{volume.config}} is sensitive to the ordering of its fields. For example, this doesn't work:
> {code}
> volume=1 size=50% scheme=http
> {code}
> but this does:
> {code}
> volume=1 scheme=http size=50%
> {code}
> All the key=value configuration files are supposed to be ordering-insensitive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)