You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/14 08:40:02 UTC
[PR] Refactor PipelineRequiredColumnsExtractor to use rule configurations [shardingsphere]
terrymanu opened a new pull request, #39843:
URL: https://github.com/apache/shardingsphere/pull/39843
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor PipelineRequiredColumnsExtractor to use rule configurations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39843:
URL: https://github.com/apache/shardingsphere/pull/39843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor PipelineRequiredColumnsExtractor to use rule configurations [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39843:
URL: https://github.com/apache/shardingsphere/pull/39843#issuecomment-5661302096
### Result
**Review Result: Mergeable**
实现符合已确认的 clean break 设计,YAML 配置已限制在转换边界内,未发现阻塞问题。
### Evidence
- `PipelineRequiredColumnsExtractor` 的公共契约已改为 `RuleConfiguration`。
- Sharding 实现直接处理 `ShardingRuleConfiguration`,不再执行 YAML 转换;`getTypeClass()` 与 Ordered SPI 精确类型匹配。
- CDC、Migration 和 Pipeline IT helper 均先通过 `YamlRuleConfigurationSwapperEngine` 转换,再调用 `OrderedSPILoader`。
- required columns、目标表过滤和大小写行为由定向测试覆盖。
- META-INF/services 注册、实现类名、持久化格式和明确非目标均未变化。
- 当前候选的定向测试、测试编译、Spotless 和 Checkstyle 均通过。
### Coverage
- 候选类型:standalone local candidate;基线 `eca8fe5430feac069589283d1ac7715af13efa37`,与本地及 `origin/master` 一致。
- 审查文件:
- `kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/importer/PipelineRequiredColumnsExtractor.java`
- `kernel/data-pipeline/feature/sharding/src/main/java/org/apache/shardingsphere/data/pipeline/sharding/PipelineShardingColumnsExtractor.java`
- `kernel/data-pipeline/feature/sharding/src/test/java/org/apache/shardingsphere/data/pipeline/sharding/PipelineShardingColumnsExtractorTest.java`
- `kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java`
- `kernel/data-pipeline/scenario/cdc/core/src/test/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJobTest.java`
- `kernel/data-pipeline/scenario/migration/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobExecutorCallback.java`
- `kernel/data-pipeline/scenario/migration/core/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/migration/MigrationJobExecutorCallbackTest.java`
- `test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/util/PipelineContextUtils.java`
- 行为集群:SPI 公共契约、Sharding 提取行为、CDC YAML 边界、Migration/IT YAML 边界。
- 已完成 root-cause、blast-radius、tests/runtime 和 convergence 检查;无未解决证据缺口。
- 本结果仅判断代码范围;未审查 GitHub Actions 或远程 CI。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org