You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/10 04:50:58 UTC

[GitHub] [iotdb] SiasDoming opened a new pull request #3382: fix iotdb-env.bat not working

SiasDoming opened a new pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382


   ## Description
   iotdb-env.bat doesn't work as expected on Windows systems due to local variable settings. This bug cause all environment variables cannot be assessed in start-server.bat, such as heap memory settings and JMX options. Besides, it's not able to calculate memory size correctly as iotdb-env.sh does due to syntax errors in lines 70, 71, 73, and 82.
   ### Variables Passing
   Delete SETLOCAL clause to make sure all variables are passing to start-server.bat. Also, system information(number of cores and physical memory size) is acquired in another way because of this modification.
   ### Value Comparisons
   Modify variable citations in GTR clauses to arithmetic operations instead of string comparisons.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #3382: fix iotdb-env.bat not working

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382#issuecomment-858323955


   
   [![Coverage Status](https://coveralls.io/builds/40463647/badge)](https://coveralls.io/builds/40463647)
   
   Coverage decreased (-0.03%) to 67.75% when pulling **db609669c6b7413b43aed2d614f671344b29c785 on SiasDoming:fix_windows_env** into **fe983ed81b97aa8b232bbdde57df08f5e9c32b0d on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #3382: fix iotdb-env.bat not working

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on pull request #3382: fix iotdb-env.bat not working

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382#issuecomment-858330254


   Hi, thanks so much for your contribution!
   
   I find out there are some lines about `SetEnvironmentVariable` in Windows CI workflow. Is it the reason why the Windows tests failed? 
   
   https://github.com/apache/iotdb/blob/fe983ed81b97aa8b232bbdde57df08f5e9c32b0d/.github/workflows/main-win.yml#L85-L88
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou removed a comment on pull request #3382: fix iotdb-env.bat not working

Posted by GitBox <gi...@apache.org>.
HTHou removed a comment on pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382#issuecomment-858330254


   Hi, thanks so much for your contribution!
   
   I find out there are some lines about `SetEnvironmentVariable` in Windows CI workflow. Is it the reason why the Windows tests failed? 
   
   https://github.com/apache/iotdb/blob/fe983ed81b97aa8b232bbdde57df08f5e9c32b0d/.github/workflows/main-win.yml#L85-L88
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SiasDoming commented on pull request #3382: fix iotdb-env.bat not working

Posted by GitBox <gi...@apache.org>.
SiasDoming commented on pull request #3382:
URL: https://github.com/apache/iotdb/pull/3382#issuecomment-858366457


   > Hi, thanks so much for your contribution!
   > 
   > I find out there are some lines about `SetEnvironmentVariable` in Windows CI workflow. Is it the reason why the Windows tests failed?
   > 
   > https://github.com/apache/iotdb/blob/fe983ed81b97aa8b232bbdde57df08f5e9c32b0d/.github/workflows/main-win.yml#L85-L88
   
   I'm not familiar with CI workflows, but it seems these lines are working with the Hadoop environment and I prefer that these have nothing to do with my modifications. All I've done is within the cope of iotdb-env.bat, which means even if the SETLOCAL clause is deleted, all variables are only valid in the lifecycle of the single command line. 
   By the way, although iotdb-env.bat may modify environment variables within the command line, thus causing errors when some variables with the same names are vital for other commands or scripts, it's mostly called by start-server.bat and the latter has a SETLOCAL clause before calling it and this will strict all variables to be valid within the start-server.bat.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org