[jira] [Comment Edited] (SLING-7083) The StopMojo should block until the process is finished

["Radu Cotescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139888#comment-16139888 ] 

Radu Cotescu edited comment on SLING-7083 at 8/24/17 11:02 AM:
---------------------------------------------------------------

Fixed in [r1806025|https://svn.apache.org/r1806025]. [~cziegeler], could you please review the fix?


was (Author: radu.cotescu):
Fixed in [r1806025|https://svn.apache.org/r1806025].

> The StopMojo should block until the process is finished
> -------------------------------------------------------
>
>                 Key: SLING-7083
>                 URL: https://issues.apache.org/jira/browse/SLING-7083
>             Project: Sling
>          Issue Type: Bug
>          Components: Tooling
>    Affects Versions: Slingstart Maven Plugin 1.1.0
>            Reporter: Radu Cotescu
>            Assignee: Radu Cotescu
>             Fix For: Slingstart Maven Plugin 1.7.8
>
>
> Currently the {{StopMojo}} blocks with a timeout only if the instance provides a control port and the stop command is sent to this socket.
> However, if the mojo has to terminate the instance process by itself then it just sends the terminate command without waiting for the process to actually finish. Without blocking, the {{verify}} Maven lifecycle phase will start, although processing of tasks started in the {{post-integration-test}} phase might not have finished.
> One of the potential side-effects of this bug is the inability to properly collect code coverage results with the {{jacoco-maven-plugin}}, because the plugin will start reading the {{*.exec}} file before its agent (usually attached to a Sling instance started by the {{StartMojo}}) had a chance to flush the coverage contents.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)