[jira] [Commented] (HBASE-13730) Backport HBASE-13576 (Failure in checking one region should not fail the entire HBCK operation) to 0.98

["Stephen Yuan Jiang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694460#comment-14694460 ] 

Stephen Yuan Jiang commented on HBASE-13730:
--------------------------------------------

[~apurtell], in my original patch, I had a cap and config to either turn off this feature or fail hbck if too many regions are skipped.  It is not in your 0.98 patch.  Is this your intension? If so, I am ok with it.  Other than that, the 0.98 patch looks good to me.

{code}
+    // If some regions is skipped during checkRegionConsistencyConcurrently() phase, we might
+    // not get accurate state of the hbase if continuing. The config here allows users to tune
+    // the tolerance of number of skipped region.
+    // TODO: evaluate the consequence to continue the hbck operation without config.
+    int terminateThreshold =  getConf().getInt("hbase.hbck.skipped.regions.limit", 0);
+    int numOfSkippedRegions = skippedRegions.size();
+    if (numOfSkippedRegions > 0 && numOfSkippedRegions > terminateThreshold) {
+      throw new IOException(numOfSkippedRegions
+        + " region(s) could not be checked or repaired.  See logs for detail.");
+    }
+
{code}

> Backport HBASE-13576 (Failure in checking one region should not fail the entire HBCK operation) to 0.98
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13730
>                 URL: https://issues.apache.org/jira/browse/HBASE-13730
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbck
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 0.98.14
>
>         Attachments: HBASE-13730-0.98.patch
>
>
> Backport HBASE-13576 - Failure in checking one region should not fail the entire HBCK operation - to 0.98



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)