You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/30 00:47:51 UTC

[GitHub] [superset] yousoph opened a new issue #12842: Update CTAS Schema from text field to a dropdown

yousoph opened a new issue #12842:
URL: https://github.com/apache/superset/issues/12842


   ## Description
   Current CTAS Schema field is a text field but users need to input the name of an existing schema for CTAS/CVAS to work as expected. 
   Instead of requiring the user to input the schema name, we should update the text field to a dropdown list of existing schemas
   (This is a follow up to Issue #12470) 
   
   ## Screenshot
   ![Add Modal - SQL Lab Settings @1456 (1)](https://user-images.githubusercontent.com/10627051/106341138-07f06480-6251-11eb-961b-9c5bdf86dac4.jpg)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mistercrunch commented on issue #12842: Update CTAS Schema from text field to a dropdown

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #12842:
URL: https://github.com/apache/superset/issues/12842#issuecomment-770132076


   BTW this field is not used very often and typically only by admins, so it's probably not a big deal to have them type the name, still nice-to-have.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mistercrunch commented on issue #12842: Update CTAS Schema from text field to a dropdown

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #12842:
URL: https://github.com/apache/superset/issues/12842#issuecomment-770131593


   I think it's a jinja-templated field and allows something like `sandbox-{username}`, let's make sure to cover that use case and make it clear the help-text underneat!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Steejay commented on issue #12842: Update CTAS Schema from text field to a dropdown

Posted by GitBox <gi...@apache.org>.
Steejay commented on issue #12842:
URL: https://github.com/apache/superset/issues/12842#issuecomment-772669825


   @mistercrunch just to clarify, users can actually _create_ new schemas in this field not just select existing schemas?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] mistercrunch edited a comment on issue #12842: Update CTAS Schema from text field to a dropdown

Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on issue #12842:
URL: https://github.com/apache/superset/issues/12842#issuecomment-770131593


   I think it's a jinja-templated field and allows something like `sandbox-{{username}}`, let's make sure to cover that use case and make it clear the help-text underneat!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org