[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1700: Fix StructArrayReader handling nested lists (#1651)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1700:
URL: https://github.com/apache/arrow-rs/pull/1700#discussion_r872415235


##########
parquet/src/arrow/array_reader/map_array.rs:
##########
@@ -154,15 +150,15 @@ impl ArrayReader for MapArrayReader {
     }
 
     fn get_def_levels(&self) -> Option<&[i16]> {
-        self.def_level_buffer
-            .as_ref()
-            .map(|buf| unsafe { buf.typed_data() })
+        // Children definition levels should describe the same parent structure,
+        // so return key_reader only
+        self.key_reader.get_def_levels()

Review Comment:
   Drive by fix, part of #1699 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org