You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2020/03/06 13:32:34 UTC

Re: Review Request 72207: RANGER-2744 : Add response header in login.jsp page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72207/
-----------------------------------------------------------

(Updated March 6, 2020, 1:32 p.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2744
    https://issues.apache.org/jira/browse/RANGER-2744


Repository: ranger


Description
-------

Good coding practice-add additional headers in ranger.


Diffs
-----

  security-admin/src/main/resources/conf.dist/security-applicationContext.xml c359971 


Diff: https://reviews.apache.org/r/72207/diff/1/


Testing
-------


Thanks,

Nitin Galave


Re: Review Request 72207: RANGER-2744 : Add response header in login.jsp page

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72207/#review220066
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On March 20, 2020, 11:05 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72207/
> -----------------------------------------------------------
> 
> (Updated March 20, 2020, 11:05 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2744
>     https://issues.apache.org/jira/browse/RANGER-2744
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice-add additional headers in ranger.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/login.jsp c5e80d1 
> 
> 
> Diff: https://reviews.apache.org/r/72207/diff/2/
> 
> 
> Testing
> -------
> 
> Problem statement
> Missing header in Response Headers of two pages
> login.jsp and XAPrelogin.js
> Solution 
> Both the above pages get loaded even before any authentication happens.
> se we are including this header explicitly in login.jsp page only.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Re: Review Request 72207: RANGER-2744 : Add response header in login.jsp page

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72207/
-----------------------------------------------------------

(Updated March 20, 2020, 11:05 a.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2744
    https://issues.apache.org/jira/browse/RANGER-2744


Repository: ranger


Description
-------

Good coding practice-add additional headers in ranger.


Diffs
-----

  security-admin/src/main/webapp/login.jsp c5e80d1 


Diff: https://reviews.apache.org/r/72207/diff/2/


Testing (updated)
-------

Problem statement
Missing header in Response Headers of two pages
login.jsp and XAPrelogin.js
Solution 
Both the above pages get loaded even before any authentication happens.
se we are including this header explicitly in login.jsp page only.


Thanks,

Nitin Galave


Re: Review Request 72207: RANGER-2744 : Add response header in login.jsp page

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72207/
-----------------------------------------------------------

(Updated March 20, 2020, 9:02 a.m.)


Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-2744
    https://issues.apache.org/jira/browse/RANGER-2744


Repository: ranger


Description
-------

Good coding practice-add additional headers in ranger.


Diffs (updated)
-----

  security-admin/src/main/webapp/login.jsp c5e80d1 


Diff: https://reviews.apache.org/r/72207/diff/2/

Changes: https://reviews.apache.org/r/72207/diff/1-2/


Testing
-------


Thanks,

Nitin Galave