[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1844: DRILL-7326: Support repeated lists for CTAS parquet format

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1844: DRILL-7326: Support repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r315587572
 
 

 ##########
 File path: exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java
 ##########
 @@ -118,6 +118,18 @@ public void endField() throws IOException {
     }
 
     public abstract void writeField() throws IOException;
+
+    /**
+     * Used by repeated converters for writing parquet logical lists. For schema details see
+     * https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists.
+     *
+     * @throws IOException
+     */
+    public void writeListField() throws IOException {
+      throw new UnsupportedOperationException(String.format(
+          "Converter '%s' doesn't support writing of list fields.",
 
 Review comment:
   ```suggestion
             "Converter '%s' doesn't support writing list fields.",
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services