You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:13:16 UTC
[GitHub] [maven-verifier-plugin] KroArtem opened a new pull request #2:
[MVERIFIER-38] Define encoding for FileReader
KroArtem opened a new pull request #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2
After discussions in https://github.com/apache/maven-verifier-plugin/pull/1 and in mailing list, I've looked at `maven-its` project and `modello` and it's not clear how to replace this plugin there. Thus I've decided to fix this small issue, update dependencies and (probably?) ask for a release.
After that this plugin can be retired. @slachiewicz , WDYT?
If you provide any ideas how to replace usages in repos mentioned above, I can do this as well. (Currently I just don't have enough knowledge about existing tools)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] michael-o commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577597085
Why not use source encoding defined in the POM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] slachiewicz commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577595394
Thx for reminder - please look for discussion on maven-dev mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-586759961
@michael-o , I've missed your comment back then :(
I've also defined encoding in pom.xml but we also discussed FileReader here: https://github.com/apache/maven-verifier-plugin/pull/1#discussion_r365546471
I still think a new version could be released, then call plugin retired and then create issues to replace this plugin from `maven-its` project and `modello`.
@slachiewicz, wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-575885839
@slachiewicz, ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577594477
@slachiewicz, ping again 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2:
[MVERIFIER-38] Define encoding for FileReader
Posted by GitBox <gi...@apache.org>.
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader
URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577597199
@slachiewicz , there was no reaction except yours. As I have wrote in this PR, this plugin is used in two places and it is not clear how to replace it there. That's why I decided it's a good idea to fix these issues, release a new version and retire plugin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services