You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/11 09:39:30 UTC
[GitHub] [cassandra] bereng opened a new pull request #622: Cassandra 15863 4.0
bereng opened a new pull request #622:
URL: https://github.com/apache/cassandra/pull/622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #622: Cassandra 15863 4.0
Posted by GitBox <gi...@apache.org>.
bereng commented on pull request #622:
URL: https://github.com/apache/cassandra/pull/622#issuecomment-642623759
- [CI j11](https://app.circleci.com/pipelines/github/bereng/cassandra/45/workflows/79ddb641-f3a5-4c07-9ae3-39302823310e)
- [CI j8](https://app.circleci.com/pipelines/github/bereng/cassandra/45/workflows/e8663c62-638f-4c9b-a501-8d1f7c227a9d)
Failures either match known failures or pass locally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a change in pull request #622: Cassandra 15863 4.0
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #622:
URL: https://github.com/apache/cassandra/pull/622#discussion_r459706030
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -1604,20 +1604,32 @@ public boolean resumeBootstrap()
@Override
public void onSuccess(StreamState streamState)
{
- bootstrapFinished();
- if(isSurveyMode)
+ try
{
- logger.info("Startup complete, but write survey mode is active, not becoming an active ring member. Use JMX (StorageService->joinRing()) to finalize ring joining.");
+ bootstrapFinished();
+ // start participating in the ring.
+ // pretend we are in survey mode so we can use joinRing() here
+ if (isSurveyMode)
+ {
+ logger.info("Startup complete, but write survey mode is active, not becoming an active ring member. Use JMX (StorageService->joinRing()) to finalize ring joining.");
+ }
+ else
+ {
+ isSurveyMode = false;
Review comment:
This assignment is superfluous, but it wasn't introduced by this patch at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #622: Cassandra 15863 4.0
Posted by GitBox <gi...@apache.org>.
bereng closed pull request #622:
URL: https://github.com/apache/cassandra/pull/622
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maedhroz commented on a change in pull request #622: Cassandra 15863 4.0
Posted by GitBox <gi...@apache.org>.
maedhroz commented on a change in pull request #622:
URL: https://github.com/apache/cassandra/pull/622#discussion_r459706030
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -1604,20 +1604,32 @@ public boolean resumeBootstrap()
@Override
public void onSuccess(StreamState streamState)
{
- bootstrapFinished();
- if(isSurveyMode)
+ try
{
- logger.info("Startup complete, but write survey mode is active, not becoming an active ring member. Use JMX (StorageService->joinRing()) to finalize ring joining.");
+ bootstrapFinished();
+ // start participating in the ring.
+ // pretend we are in survey mode so we can use joinRing() here
+ if (isSurveyMode)
+ {
+ logger.info("Startup complete, but write survey mode is active, not becoming an active ring member. Use JMX (StorageService->joinRing()) to finalize ring joining.");
+ }
+ else
+ {
+ isSurveyMode = false;
Review comment:
This assignment is superfluous, but it wasn't introduced by this patch at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org