You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/05 07:23:40 UTC

[GitHub] [incubator-tubemq] viviel opened a new pull request #132: [TUBEMQ-213] Optimize code & Minor changes

viviel opened a new pull request #132:
URL: https://github.com/apache/incubator-tubemq/pull/132


   Optimize code
   ```
   List<Message> messageList = new ArrayList<>();
   if (transferedMessageList == null || transferedMessageList.isEmpty()) {
         return messageList;
   }
   
   change to 
   
   if (transferedMessageList == null || transferedMessageList.isEmpty()) {
        return new ArrayList<>();
   }
   List<Message> messageList = new ArrayList<>(transferedMessageList.size());
   ```
   ```
   for (int i; i < 0; i++) {}
   
   change to 
   
   for (Object o; objects) {}
   ```
   ```
   String.valueOf(consumerGroup).trim();
   
   change to 
   
   consumerGroup.trim();
   ```
   etc..
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tubemq] Technoboy- merged pull request #132: [TUBEMQ-213] Optimize code & Minor changes

Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #132:
URL: https://github.com/apache/incubator-tubemq/pull/132


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org