You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by ji...@apache.org on 2022/10/27 10:05:17 UTC
[shardingsphere] branch master updated: Rename DistSQL variable related classes (#21795)
This is an automated email from the ASF dual-hosted git repository.
jianglongtao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 2b6064c2e50 Rename DistSQL variable related classes (#21795)
2b6064c2e50 is described below
commit 2b6064c2e5089857f6d89c2d43e82a25b67269fd
Author: ChenJiaHao <37...@users.noreply.github.com>
AuthorDate: Thu Oct 27 18:05:09 2022 +0800
Rename DistSQL variable related classes (#21795)
---
.../handler/distsql/ral/RALBackendHandlerFactory.java | 12 ++++++------
...riableHandler.java => ShowDistVariableHandler.java} | 4 ++--
...ablesHandler.java => ShowDistVariablesHandler.java} | 4 ++--
...ariableHandler.java => SetDistVariableHandler.java} | 4 ++--
.../handler/ProxyBackendHandlerFactoryTest.java | 4 ++--
...st.java => ShowDistVariableBackendHandlerTest.java} | 12 ++++++------
...dlerTest.java => ShowDistVariablesHandlerTest.java} | 4 ++--
...est.java => SetDistVariableBackendHandlerTest.java} | 18 +++++++++---------
...cutorTest.java => SetDistVariableExecutorTest.java} | 8 ++++----
9 files changed, 35 insertions(+), 35 deletions(-)
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/RALBackendHandlerFactory.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/RALBackendHandlerFactory.java
index 3aa460dfcb0..ef9069ce701 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/RALBackendHandlerFactory.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/RALBackendHandlerFactory.java
@@ -53,13 +53,13 @@ import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.migration.que
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.migration.update.UpdatableScalingRALBackendHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ConvertYamlConfigurationHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ExportDatabaseConfigurationHandler;
-import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowAllVariablesHandler;
+import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowDistVariablesHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowComputeNodeInfoHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowComputeNodesHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowComputeNodeModeHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowReadwriteSplittingReadResourcesHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowTableMetadataHandler;
-import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowVariableHandler;
+import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.queryable.ShowDistVariableHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.ApplyDistSQLHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.DiscardDistSQLHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.ImportDatabaseConfigurationHandler;
@@ -68,7 +68,7 @@ import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.Pre
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.RefreshTableMetadataHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetInstanceStatusHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetReadwriteSplittingStatusHandler;
-import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetVariableHandler;
+import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetDistVariableHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.UnlabelComputeNodeHandler;
import org.apache.shardingsphere.proxy.backend.session.ConnectionSession;
import org.apache.shardingsphere.readwritesplitting.distsql.parser.statement.ShowReadwriteSplittingReadResourcesStatement;
@@ -89,7 +89,7 @@ public final class RALBackendHandlerFactory {
HANDLERS.put(LabelComputeNodeStatement.class, LabelComputeNodeHandler.class);
HANDLERS.put(UnlabelComputeNodeStatement.class, UnlabelComputeNodeHandler.class);
HANDLERS.put(SetInstanceStatusStatement.class, SetInstanceStatusHandler.class);
- HANDLERS.put(SetDistVariableStatement.class, SetVariableHandler.class);
+ HANDLERS.put(SetDistVariableStatement.class, SetDistVariableHandler.class);
HANDLERS.put(SetReadwriteSplittingStatusStatement.class, SetReadwriteSplittingStatusHandler.class);
HANDLERS.put(RefreshTableMetadataStatement.class, RefreshTableMetadataHandler.class);
HANDLERS.put(PrepareDistSQLStatement.class, PrepareDistSQLHandler.class);
@@ -97,8 +97,8 @@ public final class RALBackendHandlerFactory {
HANDLERS.put(DiscardDistSQLStatement.class, DiscardDistSQLHandler.class);
HANDLERS.put(ImportDatabaseConfigurationStatement.class, ImportDatabaseConfigurationHandler.class);
HANDLERS.put(ShowComputeNodesStatement.class, ShowComputeNodesHandler.class);
- HANDLERS.put(ShowDistVariableStatement.class, ShowVariableHandler.class);
- HANDLERS.put(ShowDistVariablesStatement.class, ShowAllVariablesHandler.class);
+ HANDLERS.put(ShowDistVariableStatement.class, ShowDistVariableHandler.class);
+ HANDLERS.put(ShowDistVariablesStatement.class, ShowDistVariablesHandler.class);
HANDLERS.put(ShowReadwriteSplittingReadResourcesStatement.class, ShowReadwriteSplittingReadResourcesHandler.class);
HANDLERS.put(ShowTableMetadataStatement.class, ShowTableMetadataHandler.class);
HANDLERS.put(ExportDatabaseConfigurationStatement.class, ExportDatabaseConfigurationHandler.class);
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableHandler.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableHandler.java
similarity index 96%
rename from proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableHandler.java
rename to proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableHandler.java
index 27775863dea..b86a880c511 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableHandler.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableHandler.java
@@ -33,9 +33,9 @@ import java.util.Collection;
import java.util.Collections;
/**
- * Show variable handler.
+ * Show dist variable handler.
*/
-public final class ShowVariableHandler extends QueryableRALBackendHandler<ShowDistVariableStatement> {
+public final class ShowDistVariableHandler extends QueryableRALBackendHandler<ShowDistVariableStatement> {
private static final String VARIABLE_NAME = "variable_name";
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandler.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandler.java
similarity index 95%
rename from proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandler.java
rename to proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandler.java
index e4e4dabb3c5..5ca09605f0d 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandler.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandler.java
@@ -32,9 +32,9 @@ import java.util.Collection;
import java.util.stream.Collectors;
/**
- * Show all variables handler.
+ * Show dist variables handler.
*/
-public final class ShowAllVariablesHandler extends QueryableRALBackendHandler<ShowDistVariablesStatement> {
+public final class ShowDistVariablesHandler extends QueryableRALBackendHandler<ShowDistVariablesStatement> {
private static final String VARIABLE_NAME = "variable_name";
diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableHandler.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableHandler.java
similarity index 97%
rename from proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableHandler.java
rename to proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableHandler.java
index 2f745af6949..46b81624ff7 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableHandler.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableHandler.java
@@ -36,9 +36,9 @@ import org.apache.shardingsphere.transaction.core.TransactionType;
import java.util.Properties;
/**
- * Set variable statement handler.
+ * Set dist variable statement handler.
*/
-public final class SetVariableHandler extends UpdatableRALBackendHandler<SetDistVariableStatement> {
+public final class SetDistVariableHandler extends UpdatableRALBackendHandler<SetDistVariableStatement> {
@Override
protected void update(final ContextManager contextManager) {
diff --git a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/ProxyBackendHandlerFactoryTest.java b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/ProxyBackendHandlerFactoryTest.java
index 649164c60ca..3370c3115f2 100644
--- a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/ProxyBackendHandlerFactoryTest.java
+++ b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/ProxyBackendHandlerFactoryTest.java
@@ -37,7 +37,7 @@ import org.apache.shardingsphere.proxy.backend.handler.data.impl.UnicastDatabase
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.QueryableGlobalRuleRALBackendHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.QueryableRALBackendHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.hint.HintRALBackendHandler;
-import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetVariableHandler;
+import org.apache.shardingsphere.proxy.backend.handler.distsql.ral.updatable.SetDistVariableHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.rql.RQLBackendHandler;
import org.apache.shardingsphere.proxy.backend.handler.distsql.rul.SQLRULBackendHandler;
import org.apache.shardingsphere.proxy.backend.handler.skip.SkipBackendHandler;
@@ -116,7 +116,7 @@ public final class ProxyBackendHandlerFactoryTest extends ProxyContextRestorer {
public void assertNewInstanceWithDistSQL() throws SQLException {
String sql = "set dist variable transaction_type='LOCAL'";
ProxyBackendHandler actual = ProxyBackendHandlerFactory.newInstance(databaseType, sql, connectionSession);
- assertThat(actual, instanceOf(SetVariableHandler.class));
+ assertThat(actual, instanceOf(SetDistVariableHandler.class));
sql = "show dist variable where name = transaction_type";
actual = ProxyBackendHandlerFactory.newInstance(databaseType, sql, connectionSession);
assertThat(actual, instanceOf(QueryableRALBackendHandler.class));
diff --git a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableBackendHandlerTest.java b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableBackendHandlerTest.java
similarity index 93%
rename from proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableBackendHandlerTest.java
rename to proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableBackendHandlerTest.java
index a9814e4aff5..526940c0398 100644
--- a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowVariableBackendHandlerTest.java
+++ b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariableBackendHandlerTest.java
@@ -47,7 +47,7 @@ import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
-public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
+public final class ShowDistVariableBackendHandlerTest extends ProxyContextRestorer {
private ConnectionSession connectionSession;
@@ -61,7 +61,7 @@ public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertShowTransactionType() throws SQLException {
connectionSession.setCurrentDatabase("db");
- ShowVariableHandler backendHandler = new ShowVariableHandler();
+ ShowDistVariableHandler backendHandler = new ShowDistVariableHandler();
backendHandler.init(new ShowDistVariableStatement("transaction_type"), connectionSession);
ResponseHeader actual = backendHandler.execute();
assertThat(actual, instanceOf(QueryResponseHeader.class));
@@ -75,7 +75,7 @@ public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertShowCachedConnections() throws SQLException {
connectionSession.setCurrentDatabase("db");
- ShowVariableHandler backendHandler = new ShowVariableHandler();
+ ShowDistVariableHandler backendHandler = new ShowDistVariableHandler();
backendHandler.init(new ShowDistVariableStatement("cached_connections"), connectionSession);
ResponseHeader actual = backendHandler.execute();
assertThat(actual, instanceOf(QueryResponseHeader.class));
@@ -89,7 +89,7 @@ public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
@Test(expected = UnsupportedVariableException.class)
public void assertShowCachedConnectionFailed() {
connectionSession.setCurrentDatabase("db");
- ShowVariableHandler backendHandler = new ShowVariableHandler();
+ ShowDistVariableHandler backendHandler = new ShowDistVariableHandler();
backendHandler.init(new ShowDistVariableStatement("cached_connectionss"), connectionSession);
backendHandler.execute();
}
@@ -98,7 +98,7 @@ public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
public void assertShowAgentPluginsEnabled() throws SQLException {
SystemPropertyUtil.setSystemProperty(VariableEnum.AGENT_PLUGINS_ENABLED.name(), Boolean.TRUE.toString());
connectionSession.setCurrentDatabase("db");
- ShowVariableHandler backendHandler = new ShowVariableHandler();
+ ShowDistVariableHandler backendHandler = new ShowDistVariableHandler();
backendHandler.init(new ShowDistVariableStatement(VariableEnum.AGENT_PLUGINS_ENABLED.name()), connectionSession);
ResponseHeader actual = backendHandler.execute();
assertThat(actual, instanceOf(QueryResponseHeader.class));
@@ -119,7 +119,7 @@ public final class ShowVariableBackendHandlerTest extends ProxyContextRestorer {
Properties props = new Properties();
props.put("sql-show", Boolean.TRUE.toString());
when(metaDataContexts.getMetaData().getProps()).thenReturn(new ConfigurationProperties(props));
- ShowVariableHandler backendHandler = new ShowVariableHandler();
+ ShowDistVariableHandler backendHandler = new ShowDistVariableHandler();
backendHandler.init(new ShowDistVariableStatement("SQL_SHOW"), connectionSession);
ResponseHeader actual = backendHandler.execute();
assertThat(actual, instanceOf(QueryResponseHeader.class));
diff --git a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandlerTest.java b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandlerTest.java
similarity index 95%
rename from proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandlerTest.java
rename to proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandlerTest.java
index 180f903beca..a694c3b2123 100644
--- a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowAllVariablesHandlerTest.java
+++ b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/queryable/ShowDistVariablesHandlerTest.java
@@ -43,7 +43,7 @@ import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
-public final class ShowAllVariablesHandlerTest extends ProxyContextRestorer {
+public final class ShowDistVariablesHandlerTest extends ProxyContextRestorer {
@Before
public void setup() {
@@ -65,7 +65,7 @@ public final class ShowAllVariablesHandlerTest extends ProxyContextRestorer {
public void assertExecute() throws SQLException {
ConnectionSession connectionSession = new ConnectionSession(mock(MySQLDatabaseType.class), TransactionType.LOCAL, new DefaultAttributeMap());
connectionSession.setCurrentDatabase("foo_db");
- ShowAllVariablesHandler handler = new ShowAllVariablesHandler();
+ ShowDistVariablesHandler handler = new ShowDistVariablesHandler();
handler.init(new ShowDistVariablesStatement(), connectionSession);
ResponseHeader actual = handler.execute();
assertThat(((QueryResponseHeader) actual).getQueryHeaders().size(), is(2));
diff --git a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableBackendHandlerTest.java b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableBackendHandlerTest.java
similarity index 93%
rename from proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableBackendHandlerTest.java
rename to proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableBackendHandlerTest.java
index 1bc3d92d10f..4c0114e1846 100644
--- a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableBackendHandlerTest.java
+++ b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableBackendHandlerTest.java
@@ -56,7 +56,7 @@ import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
-public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
+public final class SetDistVariableBackendHandlerTest extends ProxyContextRestorer {
private static final String DATABASE_PATTERN = "db_%s";
@@ -93,7 +93,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertSwitchTransactionTypeXA() throws SQLException {
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(new SetDistVariableStatement("transaction_type", "XA"), connectionSession);
ResponseHeader actual = handler.execute();
assertThat(actual, instanceOf(UpdateResponseHeader.class));
@@ -103,7 +103,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertSwitchTransactionTypeBASE() throws SQLException {
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(new SetDistVariableStatement("transaction_type", "BASE"), connectionSession);
ResponseHeader actual = handler.execute();
assertThat(actual, instanceOf(UpdateResponseHeader.class));
@@ -113,7 +113,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertSwitchTransactionTypeLOCAL() throws SQLException {
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(new SetDistVariableStatement("transaction_type", "LOCAL"), connectionSession);
ResponseHeader actual = handler.execute();
assertThat(actual, instanceOf(UpdateResponseHeader.class));
@@ -122,7 +122,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test(expected = UnsupportedVariableException.class)
public void assertSwitchTransactionTypeFailed() throws SQLException {
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
handler.init(new SetDistVariableStatement("transaction_type", "XXX"), connectionSession);
handler.execute();
@@ -130,14 +130,14 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test(expected = UnsupportedVariableException.class)
public void assertNotSupportedVariable() throws SQLException {
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(new SetDistVariableStatement("@@session", "XXX"), connectionSession);
handler.execute();
}
@Test
public void assertSetAgentPluginsEnabledTrue() throws SQLException {
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
handler.init(new SetDistVariableStatement(VariableEnum.AGENT_PLUGINS_ENABLED.name(), Boolean.TRUE.toString()), null);
ResponseHeader actual = handler.execute();
@@ -147,7 +147,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertSetAgentPluginsEnabledFalse() throws SQLException {
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
handler.init(new SetDistVariableStatement(VariableEnum.AGENT_PLUGINS_ENABLED.name(), Boolean.FALSE.toString()), null);
ResponseHeader actual = handler.execute();
@@ -157,7 +157,7 @@ public final class SetVariableBackendHandlerTest extends ProxyContextRestorer {
@Test
public void assertSetAgentPluginsEnabledFalseWithUnknownValue() throws SQLException {
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
connectionSession.setCurrentDatabase(String.format(DATABASE_PATTERN, 0));
handler.init(new SetDistVariableStatement(VariableEnum.AGENT_PLUGINS_ENABLED.name(), "xxx"), connectionSession);
ResponseHeader actual = handler.execute();
diff --git a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableExecutorTest.java b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
similarity index 93%
rename from proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableExecutorTest.java
rename to proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
index 9e00e6d193e..e6108150b1c 100644
--- a/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetVariableExecutorTest.java
+++ b/proxy/backend/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/SetDistVariableExecutorTest.java
@@ -43,7 +43,7 @@ import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
-public final class SetVariableExecutorTest extends ProxyContextRestorer {
+public final class SetDistVariableExecutorTest extends ProxyContextRestorer {
@Mock
private ConnectionSession connectionSession;
@@ -52,7 +52,7 @@ public final class SetVariableExecutorTest extends ProxyContextRestorer {
public void assertExecuteWithTransactionType() throws SQLException {
SetDistVariableStatement statement = new SetDistVariableStatement("transaction_type", "local");
when(connectionSession.getTransactionStatus()).thenReturn(new TransactionStatus(TransactionType.XA));
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(statement, connectionSession);
handler.execute();
assertThat(connectionSession.getTransactionStatus().getTransactionType().name(), is(TransactionType.LOCAL.name()));
@@ -61,7 +61,7 @@ public final class SetVariableExecutorTest extends ProxyContextRestorer {
@Test
public void assertExecuteWithAgent() throws SQLException {
SetDistVariableStatement statement = new SetDistVariableStatement("AGENT_PLUGINS_ENABLED", Boolean.FALSE.toString());
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(statement, connectionSession);
handler.execute();
String actualValue = SystemPropertyUtil.getSystemProperty(VariableEnum.AGENT_PLUGINS_ENABLED.name(), "default");
@@ -73,7 +73,7 @@ public final class SetVariableExecutorTest extends ProxyContextRestorer {
ContextManager contextManager = new ContextManager(new MetaDataContexts(mock(MetaDataPersistService.class), new ShardingSphereMetaData()), null);
ProxyContext.init(contextManager);
SetDistVariableStatement statement = new SetDistVariableStatement("proxy_frontend_flush_threshold", "1024");
- SetVariableHandler handler = new SetVariableHandler();
+ SetDistVariableHandler handler = new SetDistVariableHandler();
handler.init(statement, connectionSession);
handler.execute();
Object actualValue = contextManager.getMetaDataContexts().getMetaData().getProps().getProps().get("proxy-frontend-flush-threshold");