[jira] [Commented] (OPENNLP-922) Refactor all hashCode and equals methods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815549#comment-15815549 ] 

ASF GitHub Bot commented on OPENNLP-922:
----------------------------------------

GitHub user kottmann opened a pull request:

    https://github.com/apache/opennlp/pull/42

    OPENNLP-922: Refactor equals and hashCode, add missing hashCode

    Also adds a checkstyle rule to enforce presence
    of both hashCode and equals

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kottmann/opennlp OPENNLP-922

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/42.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #42
    
----
commit 4445d9e7ba51ecfc61b422f33272adf86869ecfc
Author: Jörn Kottmann <jo...@apache.org>
Date:   2017-01-10T05:12:48Z

    OPENNLP-922: Refactor equals and hashCode, add missing hashCode
    
    Also adds a checkstyle rule to enforce presence
    of both hashCode and equals

----


> Refactor all hashCode and equals methods
> ----------------------------------------
>
>                 Key: OPENNLP-922
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-922
>             Project: OpenNLP
>          Issue Type: Improvement
>            Reporter: Joern Kottmann
>            Priority: Minor
>             Fix For: 1.7.1
>
>
> In many places Objects.hash can be used instead of some IDE generated code. This will make the implementations much more readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)