You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ch...@apache.org on 2015/07/28 07:15:52 UTC
[04/12] incubator-reef git commit: [REEF-513] Add FinalParameters to
checkstyle
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
index 1c65a00..de9b631 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/UnitClass.java
@@ -44,7 +44,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -52,7 +52,7 @@ final class UnitClass {
return false;
}
- UnitClass unitClass = (UnitClass) o;
+ final UnitClass unitClass = (UnitClass) o;
if (intValue != unitClass.intValue) {
return false;
@@ -80,7 +80,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -88,7 +88,7 @@ final class UnitClass {
return false;
}
- IntegerHandler that = (IntegerHandler) o;
+ final IntegerHandler that = (IntegerHandler) o;
if (foo != that.foo) {
return false;
@@ -112,7 +112,7 @@ final class UnitClass {
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
@@ -120,7 +120,7 @@ final class UnitClass {
return false;
}
- StringHandler that = (StringHandler) o;
+ final StringHandler that = (StringHandler) o;
if (bar != that.bar) {
return false;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
index 9991125..5c70bfe 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/evaluatorreuse/EvaluatorReuseTestDriver.java
@@ -103,7 +103,7 @@ final class EvaluatorReuseTestDriver {
try {
eb.submitContext(ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "EvaluatorReuse").build());
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
index d5fc72c..69652f9 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/fail/driver/NoopTask.java
@@ -106,7 +106,7 @@ public final class NoopTask implements Task, TaskMessageSource {
public class DriverMessageHandler implements EventHandler<DriverMessage> {
@Override
- public void onNext(DriverMessage driverMessage) {
+ public void onNext(final DriverMessage driverMessage) {
final byte[] msg = driverMessage.get().get();
LOG.log(Level.INFO, "NoopTask.DriverMessageHandler.send() invoked: {0}", CODEC.decode(msg));
synchronized (NoopTask.this) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
index 5fe85f7..165da57 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/driver/OnDriverStartedAllocateOne.java
@@ -33,7 +33,7 @@ public final class OnDriverStartedAllocateOne implements EventHandler<StartTime>
private final EvaluatorRequestor requestor;
@Inject
- OnDriverStartedAllocateOne(EvaluatorRequestor requestor) {
+ OnDriverStartedAllocateOne(final EvaluatorRequestor requestor) {
this.requestor = requestor;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
index c64869e..7648ebf 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/exceptions/ExpectedTaskException.java
@@ -25,19 +25,19 @@ public final class ExpectedTaskException extends RuntimeException {
public ExpectedTaskException() {
}
- public ExpectedTaskException(String s) {
+ public ExpectedTaskException(final String s) {
super(s);
}
- public ExpectedTaskException(String s, Throwable throwable) {
+ public ExpectedTaskException(final String s, final Throwable throwable) {
super(s, throwable);
}
- public ExpectedTaskException(Throwable throwable) {
+ public ExpectedTaskException(final Throwable throwable) {
super(throwable);
}
- public ExpectedTaskException(String s, Throwable throwable, boolean b, boolean b2) {
+ public ExpectedTaskException(final String s, final Throwable throwable, final boolean b, final boolean b2) {
super(s, throwable, b, b2);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
index 9c11ebb..4db35f8 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/EchoTask.java
@@ -32,7 +32,7 @@ public final class EchoTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return memento;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
index 9565a09..ac14697 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/library/tasks/NoopTask.java
@@ -32,7 +32,7 @@ public final class NoopTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return null;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
index 3e31330..3895c97 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/messaging/task/TaskMessagingTask.java
@@ -74,7 +74,7 @@ public final class TaskMessagingTask implements Task, TaskMessageSource {
public class DriverMessageHandler implements EventHandler<DriverMessage> {
@Override
- public void onNext(DriverMessage driverMessage) {
+ public void onNext(final DriverMessage driverMessage) {
final byte[] driverMsg = driverMessage.get().get();
LOG.log(Level.INFO, "TaskMsg.send() invoked: {0}", CODEC.decode(driverMsg));
TaskMessagingTask.this.message = Optional.of(TaskMessage.from(this.toString(), driverMsg));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
index 1d7ad8d..b46bea7 100644
--- a/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
+++ b/lang/java/reef-tests/src/main/java/org/apache/reef/tests/statepassing/StatePassingTask.java
@@ -43,7 +43,7 @@ public class StatePassingTask implements Task {
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
this.c.increment();
return makeArray(this.c.getValue(), (byte) 1);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
index ed51ca7..c6f750a 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/TestUtils.java
@@ -52,9 +52,10 @@ public final class TestUtils {
* @param clazz class inherited from type Throwable.
* @return True if ex or any other exception in its cause chain is instance of class clazz.
*/
- public static boolean hasCause(Throwable ex, final Class<? extends Throwable> clazz) {
- for (; ex != null; ex = ex.getCause()) {
- if (clazz.isInstance(ex)) {
+ public static boolean hasCause(final Throwable ex, final Class<? extends Throwable> clazz) {
+ Throwable exception = ex;
+ for (; exception != null; exception = exception.getCause()) {
+ if (clazz.isInstance(exception)) {
return true;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
index 8dda422..7cf74be 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/configurationproviders/ConfigurationProviderTestDriver.java
@@ -40,7 +40,7 @@ final class ConfigurationProviderTestDriver {
private final Injector injector;
@Inject
- private ConfigurationProviderTestDriver(EvaluatorRequestor evaluatorRequestor, Injector injector) {
+ private ConfigurationProviderTestDriver(final EvaluatorRequestor evaluatorRequestor, final Injector injector) {
this.evaluatorRequestor = evaluatorRequestor;
this.injector = injector;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
index 2c765de..11ca760 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/EvaluatorFailureDuringAlarmDriver.java
@@ -48,7 +48,7 @@ final class EvaluatorFailureDuringAlarmDriver {
final class EvaluatorAllocatedHandler implements EventHandler<AllocatedEvaluator> {
@Override
- public void onNext(AllocatedEvaluator allocatedEvaluator) {
+ public void onNext(final AllocatedEvaluator allocatedEvaluator) {
final Configuration contextConfiguration = ContextConfiguration.CONF
.set(ContextConfiguration.IDENTIFIER, "FailingEvaluator")
.set(ContextConfiguration.ON_CONTEXT_STARTED, FailureSchedulingContextStartHandler.class)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
index f60cb2d..ffa6cdd 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorfailure/FailureSchedulingContextStartHandler.java
@@ -43,7 +43,7 @@ final class FailureSchedulingContextStartHandler implements EventHandler<Context
public void onNext(final ContextStart contextStart) {
this.clock.scheduleAlarm(0, new EventHandler<Alarm>() {
@Override
- public void onNext(Alarm alarm) {
+ public void onNext(final Alarm alarm) {
LOG.log(Level.INFO, "Invoked for {0}, throwing an Exception now.", alarm);
throw new ExpectedException();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
index a8e0fc1..c8ee6ba 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestTask.java
@@ -50,7 +50,7 @@ final class FileResourceTestTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
for (final String fileName : expectedFileNames) {
final File file = new File(localFolder, fileName);
LOG.log(Level.INFO, "Testing file: " + file.getAbsolutePath());
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
index 06ab37a..4cf733b 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ActiveContextHandler.java
@@ -47,15 +47,15 @@ public final class ActiveContextHandler implements EventHandler<ActiveContext> {
}
@Override
- public void onNext(ActiveContext activeContext) {
+ public void onNext(final ActiveContext activeContext) {
LOG.log(Level.FINEST, "ActiveContext received. Submitting empty task to it");
- Configuration taskConfiguration;
+ final Configuration taskConfiguration;
try {
taskConfiguration = TaskConfiguration.CONF
.set(TaskConfiguration.IDENTIFIER, "EmptyREEFTask")
.set(TaskConfiguration.TASK, EmptyTask.class)
.build();
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new RuntimeException("Unable to setup Task configuration", e);
}
activeContext.submitTask(taskConfiguration);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
index 73b2051..0c3b6fd 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/ClosedContextHandler.java
@@ -44,7 +44,7 @@ public class ClosedContextHandler implements EventHandler<ClosedContext> {
}
@Override
- public void onNext(ClosedContext closedContext) {
+ public void onNext(final ClosedContext closedContext) {
LOG.log(Level.FINEST, "Received a closed context");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
index ab0ab13..be9625a 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedEvaluatorHandler.java
@@ -45,7 +45,7 @@ public class CompletedEvaluatorHandler implements
}
@Override
- public void onNext(CompletedEvaluator completedEvaluator) {
+ public void onNext(final CompletedEvaluator completedEvaluator) {
LOG.log(Level.FINEST, "Received a completed evaluator");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
index 2b8c0fe..96498fc 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/CompletedTaskHandler.java
@@ -44,7 +44,7 @@ public class CompletedTaskHandler implements EventHandler<CompletedTask> {
}
@Override
- public void onNext(CompletedTask completedTask) {
+ public void onNext(final CompletedTask completedTask) {
LOG.log(Level.FINEST, "Received a completed task");
completedTask.getActiveContext().close();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
index b47faad..29ad0e2 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/EmptyTask.java
@@ -32,7 +32,7 @@ public class EmptyTask implements Task {
}
@Override
- public byte[] call(byte[] memento) throws Exception {
+ public byte[] call(final byte[] memento) throws Exception {
return null;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
index 733bc04..fd419b3 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/RunningTaskHandler.java
@@ -44,7 +44,7 @@ public class RunningTaskHandler implements EventHandler<RunningTask> {
}
@Override
- public void onNext(RunningTask runningTask) {
+ public void onNext(final RunningTask runningTask) {
LOG.log(Level.FINEST, "Received a running task");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
index 0d1cc7c..cb5e61d 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/multipleEventHandlerInstances/StartHandler.java
@@ -52,7 +52,7 @@ public final class StartHandler implements EventHandler<StartTime> {
}
@Override
- public void onNext(StartTime startTime) {
+ public void onNext(final StartTime startTime) {
LOG.log(Level.INFO, "StartTime: ", startTime);
StartHandler.this.requestor.submit(EvaluatorRequest.newBuilder()
.setNumber(5)
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
index 8a3dbf7..ea19843 100644
--- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
+++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
@@ -66,7 +66,7 @@ final class WrappedValue<V> {
public synchronized V loadAndGet() throws ExecutionException {
try {
value = Optional.ofNullable(valueFetcher.call());
- } catch (Exception e) {
+ } catch (final Exception e) {
throw new ExecutionException(e);
} finally {
writeTime = Optional.of(currentTime.now());
@@ -83,7 +83,7 @@ final class WrappedValue<V> {
while (!value.isPresent()) {
try {
this.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
// Ignore, as while loop will be re-entered
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
index 64e55e9..7c634d6 100644
--- a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
+++ b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/CacheImplConcurrentTest.java
@@ -66,7 +66,7 @@ public final class CacheImplConcurrentTest {
// Assert that firstValue is returned, even when other gets are called during the Callable execution
getFirstValue1 = cache.get(key, new SleepingInteger(firstValue, computationMillis));
assertEquals(firstValue, getFirstValue1);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -83,7 +83,7 @@ public final class CacheImplConcurrentTest {
// The original cached value should be retrieved
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(firstValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -120,7 +120,7 @@ public final class CacheImplConcurrentTest {
public void run() {
try {
getValues[index] = cache.get(key, new ImmediateInteger(values[index]));
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -157,7 +157,7 @@ public final class CacheImplConcurrentTest {
// Assert that firstValue is returned, even when it is invalidated during the Callable execution
getFirstValue1 = cache.get(key, new SleepingInteger(firstValue, computationMillis));
assertEquals(firstValue, getFirstValue1);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
@@ -178,7 +178,7 @@ public final class CacheImplConcurrentTest {
// The original cached value should be retrieved, even when it is invalidated during the Callable execution
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(firstValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
} else {
@@ -186,7 +186,7 @@ public final class CacheImplConcurrentTest {
// The second value should be retrieved, because the cache has been invalidated
final int getFirstValue2 = cache.get(key, new ImmediateInteger(secondValue));
assertEquals(secondValue, getFirstValue2);
- } catch (ExecutionException e) {
+ } catch (final ExecutionException e) {
throw new RuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
index 374fcdd..f244083 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/AbstractEStage.java
@@ -43,7 +43,7 @@ public abstract class AbstractEStage<T> implements EStage<T> {
*
* @parm stageName the stage name
*/
- public AbstractEStage(String stageName) {
+ public AbstractEStage(final String stageName) {
this.closed = new AtomicBoolean(false);
this.name = stageName;
this.inMeter = new Meter(stageName + "_in");
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
index 437dd9a..7f8ccf1 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/IdentifierParser.java
@@ -32,7 +32,7 @@ public class IdentifierParser implements ExternalConstructor<Identifier> {
// TODO: Modify tang to allow this to use a factory pattern.
static {
- Map<String, Class<? extends Identifier>> map = new ConcurrentHashMap<>();
+ final Map<String, Class<? extends Identifier>> map = new ConcurrentHashMap<>();
map.put("socket", SocketRemoteIdentifier.class);
map.put("file", FileIdentifier.class);
@@ -43,7 +43,7 @@ public class IdentifierParser implements ExternalConstructor<Identifier> {
final Identifier id;
@Inject
- IdentifierParser(String s) {
+ IdentifierParser(final String s) {
id = FACTORY.getNewInstance(s);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
index 57d817a..3c8d787 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/WakeConfiguration.java
@@ -44,13 +44,13 @@ public final class WakeConfiguration {
if (confFileName.equals("")) {
LOG.log(Level.WARNING, "The Wake configuration file is not specified.");
} else {
- Tang t = Tang.Factory.getTang();
- JavaConfigurationBuilder cb = t.newConfigurationBuilder();
+ final Tang t = Tang.Factory.getTang();
+ final JavaConfigurationBuilder cb = t.newConfigurationBuilder();
try {
ConfigurationFile.addConfiguration(cb, new File(confFileName));
- } catch (BindException e) {
+ } catch (final BindException e) {
throw new WakeRuntimeException(e);
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new WakeRuntimeException(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
index 6741d35..da0b04c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
@@ -33,7 +33,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
private final ConcurrentSkipListMap<K, V> register = new ConcurrentSkipListMap<>();
private volatile boolean done = false;
- public CombinerStage(Combiner<K, V> c, Observer<Map.Entry<K, V>> o) {
+ public CombinerStage(final Combiner<K, V> c, final Observer<Map.Entry<K, V>> o) {
this.c = c;
this.o = o;
worker.start();
@@ -42,10 +42,10 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
public Observer<Map.Entry<K, V>> wireIn() {
return new Observer<Map.Entry<K, V>>() {
@Override
- public void onNext(Map.Entry<K, V> pair) {
+ public void onNext(final Map.Entry<K, V> pair) {
V old;
V newVal;
- boolean wasEmpty = register.isEmpty();
+ final boolean wasEmpty = register.isEmpty();
boolean succ = false;
while (!succ) {
@@ -66,7 +66,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
o.onError(error);
}
@@ -95,13 +95,13 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
private final K k;
private final V v;
- public Pair(K k, V v) {
+ public Pair(final K k, final V v) {
this.k = k;
this.v = v;
}
@Override
- public int compareTo(Map.Entry<K, V> arg0) {
+ public int compareTo(final Map.Entry<K, V> arg0) {
return k.compareTo(arg0.getKey());
}
@@ -116,7 +116,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
}
@Override
- public V setValue(V value) {
+ public V setValue(final V value) {
throw new UnsupportedOperationException();
}
}
@@ -134,7 +134,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
while (register.isEmpty() && !done) {
try {
register.wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new IllegalStateException(e);
}
}
@@ -146,7 +146,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
Map.Entry<K, V> cursor = register.pollFirstEntry();
while (cursor != null) {
o.onNext(cursor);
- K nextKey = register.higherKey(cursor.getKey());
+ final K nextKey = register.higherKey(cursor.getKey());
/* If there is more than one OutputThread worker then the remove() -> null case
* must be handled
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
index 72c6ea6..b70e9df 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/BlockingJoin.java
@@ -29,7 +29,7 @@ public class BlockingJoin implements StaticObservable {
private final ConcurrentSkipListSet<TupleEvent> left = new ConcurrentSkipListSet<>();
boolean leftDone = false;
- public BlockingJoin(Observer<TupleEvent> out) {
+ public BlockingJoin(final Observer<TupleEvent> out) {
this.out = out;
}
@@ -42,7 +42,7 @@ public class BlockingJoin implements StaticObservable {
while (!leftDone) {
try {
wait();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
throw new IllegalStateException(
"No support for interrupted threads here!", e);
}
@@ -53,12 +53,12 @@ public class BlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
left.add(value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
}
@@ -74,7 +74,7 @@ public class BlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
if (!leftDone) {
waitUntilLeftIsDone();
}
@@ -84,7 +84,7 @@ public class BlockingJoin implements StaticObservable {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
index cf8be97..26e0685 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/EventPrinter.java
@@ -23,12 +23,12 @@ import org.apache.reef.wake.rx.Observer;
public class EventPrinter<T> implements Observer<T> {
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
System.out.println(this + ": " + value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
System.err.println(this + ": " + error);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
index bb922d3..2f864d3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/NonBlockingJoin.java
@@ -35,7 +35,7 @@ public class NonBlockingJoin implements StaticObservable {
private final ConcurrentSkipListSet<TupleEvent> leftTable = new ConcurrentSkipListSet<TupleEvent>();
private final ConcurrentSkipListSet<TupleEvent> rightTable = new ConcurrentSkipListSet<TupleEvent>();
- public NonBlockingJoin(Observer<TupleEvent> out) {
+ public NonBlockingJoin(final Observer<TupleEvent> out) {
this.out = out;
}
@@ -69,12 +69,12 @@ public class NonBlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
leftTable.add(value);
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
leftTable.clear();
rightTable.clear();
out.onError(error);
@@ -93,7 +93,7 @@ public class NonBlockingJoin implements StaticObservable {
return new Observer<TupleEvent>() {
@Override
- public void onNext(TupleEvent value) {
+ public void onNext(final TupleEvent value) {
if (leftTable.contains(value)) {
out.onNext(value);
} else if (!leftDone.get()) {
@@ -103,7 +103,7 @@ public class NonBlockingJoin implements StaticObservable {
}
@Override
- public void onError(Exception error) {
+ public void onError(final Exception error) {
leftTable.clear();
rightTable.clear();
out.onError(error);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
index 57dd6f2..4084730 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleEvent.java
@@ -23,14 +23,14 @@ public class TupleEvent implements Comparable<TupleEvent> {
private final int key;
private final String val;
- public TupleEvent(int key, String val) {
+ public TupleEvent(final int key, final String val) {
this.key = key;
this.val = val;
}
@Override
- public int compareTo(TupleEvent o) {
- int keycmp = Integer.compare(key, o.key);
+ public int compareTo(final TupleEvent o) {
+ final int keycmp = Integer.compare(key, o.key);
if (keycmp != 0) {
return keycmp;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
index 16590a9..22ed659 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/join/TupleSource.java
@@ -50,7 +50,7 @@ public class TupleSource implements StaticObservable, Stage {
@Override
public void close() throws Exception {
- for (Thread t : threads) {
+ for (final Thread t : threads) {
t.join();
}
out.onCompleted();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
index d27b719..60604d3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingEventHandler.java
@@ -53,7 +53,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
@Override
public void onNext(final T event) {
this.events.add(event);
- int newCursor = this.cursor.incrementAndGet();
+ final int newCursor = this.cursor.incrementAndGet();
if (newCursor % expectedSize == 0) {
// FIXME: There is a race here where the person draining the events might
@@ -61,7 +61,7 @@ public final class BlockingEventHandler<T> implements EventHandler<T> {
// matter, since all events will still be drained exactly once by someone in
// the proper order
- ArrayList<T> nonConcurrent = new ArrayList<>(expectedSize);
+ final ArrayList<T> nonConcurrent = new ArrayList<>(expectedSize);
synchronized (events) {
// drainTo(maxElements) does not suffice because it has undefined behavior for
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
index 7b582bb..5c1869c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/BlockingSignalEventHandler.java
@@ -47,7 +47,7 @@ public final class BlockingSignalEventHandler<T> implements EventHandler<T> {
@Override
public void onNext(final T event) {
- int newSize = this.cursor.incrementAndGet();
+ final int newSize = this.cursor.incrementAndGet();
if (newSize % expectedSize == 0) {
this.destination.onNext(event);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
index 05cc7ef..231262f 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultIdentifierFactory.java
@@ -56,7 +56,7 @@ public class DefaultIdentifierFactory implements IdentifierFactory {
*
* @param typeToClazzMap the map of type strings to classes of remote identifiers
*/
- public DefaultIdentifierFactory(Map<String, Class<? extends Identifier>> typeToClazzMap) {
+ public DefaultIdentifierFactory(final Map<String, Class<? extends Identifier>> typeToClazzMap) {
this.typeToClazzMap = typeToClazzMap;
}
@@ -68,18 +68,18 @@ public class DefaultIdentifierFactory implements IdentifierFactory {
* @throws RemoteRuntimeException
*/
@Override
- public Identifier getNewInstance(String str) {
- int index = str.indexOf("://");
+ public Identifier getNewInstance(final String str) {
+ final int index = str.indexOf("://");
if (index < 0) {
throw new RemoteRuntimeException("Invalid name " + str);
}
- String type = str.substring(0, index);
- Class<? extends Identifier> clazz = typeToClazzMap.get(type);
- Class<?>[] argTypes = {String.class};
- Constructor<? extends Identifier> constructor;
+ final String type = str.substring(0, index);
+ final Class<? extends Identifier> clazz = typeToClazzMap.get(type);
+ final Class<?>[] argTypes = {String.class};
+ final Constructor<? extends Identifier> constructor;
try {
constructor = clazz.getDeclaredConstructor(argTypes);
- Object[] args = new Object[1];
+ final Object[] args = new Object[1];
args[0] = str.substring(index + 3);
return constructor.newInstance(args);
} catch (NoSuchMethodException | SecurityException | InstantiationException | IllegalAccessException |
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
index 839a13f..53c6efb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/DefaultThreadFactory.java
@@ -36,8 +36,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
*
* @param prefix the name prefix of the created thread
*/
- public DefaultThreadFactory(String prefix) {
- SecurityManager s = System.getSecurityManager();
+ public DefaultThreadFactory(final String prefix) {
+ final SecurityManager s = System.getSecurityManager();
this.group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
this.prefix = prefix + "-pool-" + POOL_NUMBER.getAndIncrement() + "-thread-";
this.uncaughtExceptionHandler = null;
@@ -49,8 +49,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
* @param prefix the name prefix of the created thread
* @param uncaughtExceptionHandler the uncaught exception handler of the created thread
*/
- public DefaultThreadFactory(String prefix, Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
- SecurityManager s = System.getSecurityManager();
+ public DefaultThreadFactory(final String prefix, final Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
+ final SecurityManager s = System.getSecurityManager();
this.group = (s != null) ? s.getThreadGroup() : Thread.currentThread().getThreadGroup();
this.prefix = prefix + "-pool-" + POOL_NUMBER.getAndIncrement() + "-thread-";
this.uncaughtExceptionHandler = uncaughtExceptionHandler;
@@ -61,7 +61,7 @@ public final class DefaultThreadFactory implements ThreadFactory {
*
* @param uncaughtExceptionHandler the uncaught exception handler
*/
- public void setUncaughtExceptionHandler(Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
+ public void setUncaughtExceptionHandler(final Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
this.uncaughtExceptionHandler = uncaughtExceptionHandler;
}
@@ -71,8 +71,8 @@ public final class DefaultThreadFactory implements ThreadFactory {
* @param r the runnable
*/
@Override
- public Thread newThread(Runnable r) {
- Thread t = new Thread(group, r, prefix + threadNumber.getAndIncrement(), 0);
+ public Thread newThread(final Runnable r) {
+ final Thread t = new Thread(group, r, prefix + threadNumber.getAndIncrement(), 0);
if (t.isDaemon()) {
t.setDaemon(false);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
index e08a31b..9018e1d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ForkPoolStage.java
@@ -50,9 +50,9 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
private final WakeSharedPool pool;
@Inject
- public ForkPoolStage(@Parameter(StageConfiguration.StageName.class) String stageName,
- @Parameter(StageConfiguration.StageHandler.class) EventHandler<T> handler,
- WakeSharedPool sharedPool
+ public ForkPoolStage(@Parameter(StageConfiguration.StageName.class) final String stageName,
+ @Parameter(StageConfiguration.StageHandler.class) final EventHandler<T> handler,
+ final WakeSharedPool sharedPool
) {
super(stageName);
this.pool = sharedPool;
@@ -63,8 +63,8 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
}
@Inject
- public ForkPoolStage(@Parameter(StageConfiguration.StageHandler.class) EventHandler<T> handler,
- WakeSharedPool sharedPool) {
+ public ForkPoolStage(@Parameter(StageConfiguration.StageHandler.class) final EventHandler<T> handler,
+ final WakeSharedPool sharedPool) {
this(ForkPoolStage.class.getName(), handler, sharedPool);
}
@@ -80,7 +80,7 @@ public class ForkPoolStage<T> extends AbstractEStage<T> {
}
@Override
- protected void setRawResult(T value) {
+ protected void setRawResult(final T value) {
// tasks have no results because they are events
// this may be used for extensions
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
index 11048fc..91a2352 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/IndependentIterationsThreadPoolStage.java
@@ -42,7 +42,8 @@ public class IndependentIterationsThreadPoolStage<T> extends AbstractEStage<List
private EventHandler<T> handler;
private ExecutorService executor;
- public IndependentIterationsThreadPoolStage(EventHandler<T> handler, int numThreads, int granularity) {
+ public IndependentIterationsThreadPoolStage(
+ final EventHandler<T> handler, final int numThreads, final int granularity) {
super(handler.getClass().getName());
this.handler = handler;
this.executor = Executors.newFixedThreadPool(numThreads);
@@ -53,7 +54,7 @@ public class IndependentIterationsThreadPoolStage<T> extends AbstractEStage<List
return new Runnable() {
@Override
public void run() {
- for (T e : iterations) {
+ for (final T e : iterations) {
handler.onNext(e);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
index 3a4da62..8dab064 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingEventHandler.java
@@ -42,7 +42,7 @@ public class LoggingEventHandler<T> implements EventHandler<T> {
* @param value an event
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
LOG.log(Level.FINE, "{0}", value);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
index 597861b..c3ba8d6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingUtils.java
@@ -33,10 +33,10 @@ public final class LoggingUtils {
*
* @param level the logging level
*/
- public static void setLoggingLevel(Level level) {
- Handler[] handlers = Logger.getLogger("").getHandlers();
+ public static void setLoggingLevel(final Level level) {
+ final Handler[] handlers = Logger.getLogger("").getHandlers();
ConsoleHandler ch = null;
- for (Handler h : handlers) {
+ for (final Handler h : handlers) {
if (h instanceof ConsoleHandler) {
ch = (ConsoleHandler) h;
break;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
index 8d91e86..2681d19 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/LoggingVoidEventHandler.java
@@ -40,7 +40,7 @@ public class LoggingVoidEventHandler implements EventHandler<Void> {
* @param value an event
*/
@Override
- public void onNext(Void value) {
+ public void onNext(final Void value) {
LOG.log(Level.FINE, "Logging void event handler");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
index 8a99311..07771a0 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MergingEventHandler.java
@@ -64,7 +64,7 @@ public final class MergingEventHandler<L, R> {
public final S1 first;
public final S2 second;
- private Pair(S1 s1, S2 s2) {
+ private Pair(final S1 s1, final S2 s2) {
this.first = s1;
this.second = s2;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
index e2f9923..9d8de3d 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/MultiEventHandler.java
@@ -37,7 +37,7 @@ public class MultiEventHandler<T> implements EventHandler<T> {
*
* @param map a map of class types to event handlers
*/
- public MultiEventHandler(Map<Class<? extends T>, EventHandler<? extends T>> map) {
+ public MultiEventHandler(final Map<Class<? extends T>, EventHandler<? extends T>> map) {
this.map = map;
}
@@ -48,8 +48,8 @@ public class MultiEventHandler<T> implements EventHandler<T> {
* @throws WakeRuntimeException
*/
@Override
- public void onNext(T event) {
- EventHandler<T> handler = (EventHandler<T>) map.get(event.getClass());
+ public void onNext(final T event) {
+ final EventHandler<T> handler = (EventHandler<T>) map.get(event.getClass());
if (handler == null) {
throw new WakeRuntimeException("No event " + event.getClass() + " handler");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
index c3b5ba9..5667eb5 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/PubSubEventHandler.java
@@ -53,7 +53,7 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
*
* @param map a map of event class types to lists of event handlers
*/
- public PubSubEventHandler(Map<Class<? extends T>, List<EventHandler<? extends T>>> clazzToListOfHandlersMap) {
+ public PubSubEventHandler(final Map<Class<? extends T>, List<EventHandler<? extends T>>> clazzToListOfHandlersMap) {
this.clazzToListOfHandlersMap = clazzToListOfHandlersMap;
}
@@ -63,7 +63,7 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
* @param clazz an event class
* @param handler an event handler
*/
- public void subscribe(Class<? extends T> clazz, EventHandler<? extends T> handler) {
+ public void subscribe(final Class<? extends T> clazz, final EventHandler<? extends T> handler) {
lock.writeLock().lock();
try {
List<EventHandler<? extends T>> list = clazzToListOfHandlersMap.get(clazz);
@@ -84,10 +84,10 @@ public class PubSubEventHandler<T> implements EventHandler<T> {
* @throws WakeRuntimeException
*/
@Override
- public void onNext(T event) {
+ public void onNext(final T event) {
LOG.log(Level.FINEST, "Invoked for event: {0}", event);
lock.readLock().lock();
- List<EventHandler<? extends T>> list;
+ final List<EventHandler<? extends T>> list;
try {
list = clazzToListOfHandlersMap.get(event.getClass());
if (list == null) {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
index 6bd0455..033a1cb 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SingleThreadStage.java
@@ -84,7 +84,7 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
* @throws IllegalStateException
*/
@Override
- public void onNext(T value) {
+ public void onNext(final T value) {
beforeOnNext();
queue.add(value);
}
@@ -113,7 +113,8 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
private final EventHandler<U> handler;
private final AtomicBoolean interrupted;
- Producer(String name, BlockingQueue<U> queue, EventHandler<U> handler, AtomicBoolean interrupted) {
+ Producer(final String name, final BlockingQueue<U> queue, final EventHandler<U> handler,
+ final AtomicBoolean interrupted) {
this.name = name;
this.queue = queue;
this.handler = handler;
@@ -124,15 +125,15 @@ public final class SingleThreadStage<T> extends AbstractEStage<T> {
public void run() {
while (true) {
try {
- U value = queue.take();
+ final U value = queue.take();
handler.onNext(value);
SingleThreadStage.this.afterOnNext();
- } catch (InterruptedException e) {
+ } catch (final InterruptedException e) {
if (interrupted.get()) {
LOG.log(Level.FINEST, name + " Closing Producer due to interruption");
break;
}
- } catch (Throwable t) {
+ } catch (final Throwable t) {
LOG.log(Level.SEVERE, name + " Exception from event handler", t);
throw t;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
index 547ab7d..806428e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/SyncStage.java
@@ -90,7 +90,7 @@ public final class SyncStage<T> extends AbstractEStage<T> {
beforeOnNext();
try {
handler.onNext(value);
- } catch (Throwable t) {
+ } catch (final Throwable t) {
if (errorHandler != null) {
errorHandler.onNext(t);
} else {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
index 483a7e4..451e6cd 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/ThreadPoolStage.java
@@ -180,7 +180,7 @@ public final class ThreadPoolStage<T> extends AbstractEStage<T> {
try {
handler.onNext(value);
afterOnNext();
- } catch (Throwable t) {
+ } catch (final Throwable t) {
if (errorHandler != null) {
errorHandler.onNext(t);
} else {
@@ -205,7 +205,7 @@ public final class ThreadPoolStage<T> extends AbstractEStage<T> {
executor.shutdown();
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
index 191110c..7b055b3 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/TimerStage.java
@@ -127,7 +127,7 @@ public final class TimerStage implements Stage {
executor.shutdown();
if (!executor.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = executor.shutdownNow();
+ final List<Runnable> droppedRunnables = executor.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
index 546747e..3a43925 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeSharedPool.java
@@ -55,11 +55,11 @@ public class WakeSharedPool implements Stage {
private AtomicBoolean closed = new AtomicBoolean(false);
@Inject
- public WakeSharedPool(@Parameter(Parallelism.class) int parallelism) {
+ public WakeSharedPool(@Parameter(Parallelism.class) final int parallelism) {
this.pool = new ForkJoinPool(parallelism, ForkJoinPool.defaultForkJoinWorkerThreadFactory,
new Thread.UncaughtExceptionHandler() {
@Override
- public void uncaughtException(Thread t, Throwable e) {
+ public void uncaughtException(final Thread t, final Throwable e) {
// TODO: need to pass this upwards to REEF can grab it
}
},
@@ -82,7 +82,7 @@ public class WakeSharedPool implements Stage {
this(DEFAULT_PARALLELISM);
}
- public void submit(ForkJoinTask<?> t) {
+ public void submit(final ForkJoinTask<?> t) {
if (ForkJoinTask.inForkJoinPool()) {
ForkJoinTask.invokeAll(t);
// alternatively just pool().pool.execute(t), which simply forces it to be this pool
@@ -99,7 +99,7 @@ public class WakeSharedPool implements Stage {
pool.shutdown();
if (!pool.awaitTermination(shutdownTimeout, TimeUnit.MILLISECONDS)) {
LOG.log(Level.WARNING, "Executor did not terminate in " + shutdownTimeout + "ms.");
- List<Runnable> droppedRunnables = pool.shutdownNow();
+ final List<Runnable> droppedRunnables = pool.shutdownNow();
LOG.log(Level.WARNING, "Executor dropped " + droppedRunnables.size() + " tasks.");
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
index f729fbe..b081cee 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/impl/WakeUncaughtExceptionHandler.java
@@ -33,12 +33,12 @@ public final class WakeUncaughtExceptionHandler implements Thread.UncaughtExcept
this.errorHandler = errorHandler;
}
- public void setErrorHandler(EventHandler<Throwable> errorHandler) {
+ public void setErrorHandler(final EventHandler<Throwable> errorHandler) {
this.errorHandler = errorHandler;
}
@Override
- public void uncaughtException(Thread t, Throwable e) {
+ public void uncaughtException(final Thread t, final Throwable e) {
final String msg = "Thread " + t.getName() + " threw an uncaught exception.";
if (errorHandler != null) {
errorHandler.onNext(new Exception(msg, e));
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
index 35c35fb..b10b215 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/EWMA.java
@@ -39,7 +39,7 @@ public class EWMA {
* @param interval
* @param intervalUnit
*/
- public EWMA(double alpha, long interval, TimeUnit intervalUnit) {
+ public EWMA(final double alpha, final long interval, final TimeUnit intervalUnit) {
this.interval = intervalUnit.toNanos(interval);
this.alpha = alpha;
}
@@ -49,7 +49,7 @@ public class EWMA {
*
* @param n the new value
*/
- public void update(long n) {
+ public void update(final long n) {
uncounted.addAndGet(n);
}
@@ -73,7 +73,7 @@ public class EWMA {
* @param rateUnit the unit of the rate
* @return the rate
*/
- public double getRate(TimeUnit rateUnit) {
+ public double getRate(final TimeUnit rateUnit) {
return rate * (double) rateUnit.toNanos(1);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
index 588fd4d..8bf1022 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/Meter.java
@@ -43,7 +43,7 @@ public class Meter {
*
* @param name the name of the meter
*/
- public Meter(String name) {
+ public Meter(final String name) {
this.name = name;
this.m1Thp = new EWMA(EWMAParameters.M1_ALPHA, EWMAParameters.INTERVAL, TimeUnit.SECONDS);
this.m5Thp = new EWMA(EWMAParameters.M5_ALPHA, EWMAParameters.INTERVAL, TimeUnit.SECONDS);
@@ -66,7 +66,7 @@ public class Meter {
*
* @param n the number of events
*/
- public void mark(long n) {
+ public void mark(final long n) {
tickIfNecessary();
count.addAndGet(n);
m1Thp.update(n);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
index c2869ae..39e08b4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/metrics/UniformHistogram.java
@@ -36,7 +36,7 @@ public class UniformHistogram implements Histogram {
* @param binWidth the width of each bin
* @param numBins the number of bins
*/
- public UniformHistogram(long binWidth, int numBins) {
+ public UniformHistogram(final long binWidth, final int numBins) {
this.count = new AtomicLong(0);
this.values = new AtomicLongArray(numBins);
this.binWidth = binWidth;
@@ -49,7 +49,7 @@ public class UniformHistogram implements Histogram {
* @param value
*/
@Override
- public void update(long value) {
+ public void update(final long value) {
count.incrementAndGet();
int index = (int) (value / binWidth);
if (index >= numBins) {
@@ -75,7 +75,7 @@ public class UniformHistogram implements Histogram {
* @return the value of the index
*/
@Override
- public long getValue(int index) {
+ public long getValue(final int index) {
return values.get(index);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
index 0ea7d28..593a219 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/Vertex.java
@@ -32,7 +32,8 @@ public class Vertex<T> {
private final Vertex<?>[] constructorArguments;
// private final Set<Object> referencesToThisObject = new MonotonicHashSet<>();
- public Vertex(T object, String name, ConstructorDef<T> constructorDef, Vertex<?>[] constructorArguments) {
+ public Vertex(final T object, final String name, final ConstructorDef<T> constructorDef,
+ final Vertex<?>[] constructorArguments) {
this.object = object;
if (object == null) {
throw new NullPointerException();
@@ -40,14 +41,14 @@ public class Vertex<T> {
this.name = name;
this.constructorDef = constructorDef;
this.constructorArguments = constructorArguments;
- for (Vertex<?> v : constructorArguments) {
+ for (final Vertex<?> v : constructorArguments) {
if (v == null) {
throw new NullPointerException();
}
}
}
- public Vertex(T object, ConstructorDef<T> constructorDef, Vertex<?>[] constructorArguments) {
+ public Vertex(final T object, final ConstructorDef<T> constructorDef, final Vertex<?>[] constructorArguments) {
this.object = object;
if (object == null) {
throw new NullPointerException();
@@ -55,14 +56,14 @@ public class Vertex<T> {
this.name = null;
this.constructorDef = constructorDef;
this.constructorArguments = constructorArguments;
- for (Vertex<?> v : constructorArguments) {
+ for (final Vertex<?> v : constructorArguments) {
if (v == null) {
throw new NullPointerException();
}
}
}
- public Vertex(Object object) {
+ public Vertex(final Object object) {
this.object = object;
if (object == null) {
throw new NullPointerException();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
index 927815a..72714d6 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/profiler/WakeProfiler.java
@@ -47,7 +47,7 @@ public class WakeProfiler implements Aspect {
}
@SuppressWarnings("unchecked")
- private <T> Vertex<T> getVertex(T t) {
+ private <T> Vertex<T> getVertex(final T t) {
if (t instanceof Set) {
return (Vertex<T>) newSetVertex((Set<?>) t);
} else {
@@ -62,30 +62,30 @@ public class WakeProfiler implements Aspect {
}
@SuppressWarnings("unchecked")
- private <T> Vertex<T> getFuture(InjectionFuture<T> future) {
+ private <T> Vertex<T> getFuture(final InjectionFuture<T> future) {
return getVertex((T) futures.get(future));
}
@SuppressWarnings("unchecked")
- private <T> Vertex<?> newSetVertex(Set<T> s) {
+ private <T> Vertex<?> newSetVertex(final Set<T> s) {
if (vertexObject.containsKey(s)) {
return (Vertex<Set<T>>) vertexObject.get(s);
}
if (s.size() > -1) {
LOG.fine("new set of size " + s.size());
- Vertex<?>[] sArgs = new Vertex[s.size()];
+ final Vertex<?>[] sArgs = new Vertex[s.size()];
int k = 0;
- for (Object p : s) {
+ for (final Object p : s) {
sArgs[k] = getVertex(p);
k++;
}
- Vertex<Set<T>> sv = new Vertex<>(s, null, sArgs);
+ final Vertex<Set<T>> sv = new Vertex<>(s, null, sArgs);
vertexObject.put(s, sv);
return sv;
// } else if(s.size() == 1) {
} else {
- Object p = s.iterator().next();
- Vertex<?> w = getVertex(p);
+ final Object p = s.iterator().next();
+ final Vertex<?> w = getVertex(p);
// alias the singleton set to its member
vertexObject.put(s, w);
return w;
@@ -97,13 +97,13 @@ public class WakeProfiler implements Aspect {
@SuppressWarnings("unchecked")
@Override
- public <T> T inject(ConstructorDef<T> constructorDef, Constructor<T> constructor, Object[] args)
+ public <T> T inject(final ConstructorDef<T> constructorDef, final Constructor<T> constructor, final Object[] args)
throws InvocationTargetException, IllegalAccessException, IllegalArgumentException, InstantiationException {
// LOG.info("inject" + constructor + "->" + args.length);
- Vertex<?>[] vArgs = new Vertex[args.length];
+ final Vertex<?>[] vArgs = new Vertex[args.length];
for (int i = 0; i < args.length; i++) {
- Object o = args[i];
- Vertex<?> v = getVertex(o);
+ final Object o = args[i];
+ final Vertex<?> v = getVertex(o);
if (o instanceof Set) {
LOG.fine("Got a set arg for " + constructorDef + " length " + ((Set<?>) o).size());
}
@@ -113,7 +113,7 @@ public class WakeProfiler implements Aspect {
T ret;
final Class<T> clazz = constructor.getDeclaringClass();
boolean isEventHandler = false;
- for (Method m : clazz.getDeclaredMethods()) {
+ for (final Method m : clazz.getDeclaredMethods()) {
if (m.getName().equals("onNext")) { // XXX hack: Interpose on "event handler in spirit"
isEventHandler = true;
}
@@ -124,19 +124,19 @@ public class WakeProfiler implements Aspect {
throw new Exception(ReflectionUtilities.getFullName(clazz) + ".onNext() is final; cannot intercept it");
}
final Stats s = new Stats();
- Enhancer e = new Enhancer();
+ final Enhancer e = new Enhancer();
e.setSuperclass(clazz);
e.setCallback(new MethodInterceptor() {
@Override
- public Object intercept(Object object, Method method, Object[] args,
- MethodProxy methodProxy) throws Throwable {
+ public Object intercept(final Object object, final Method method, final Object[] args,
+ final MethodProxy methodProxy) throws Throwable {
if (method.getName().equals("onNext")) {
- long start = System.nanoTime();
+ final long start = System.nanoTime();
// LOG.info(object + "." + method.getName() + " called");
- Object o = methodProxy.invokeSuper(object, args);
- long stop = System.nanoTime();
+ final Object o = methodProxy.invokeSuper(object, args);
+ final long stop = System.nanoTime();
s.messageCount.incrementAndGet();
s.sumLatency.addAndGet(stop - start);
@@ -150,20 +150,20 @@ public class WakeProfiler implements Aspect {
});
ret = (T) e.create(constructor.getParameterTypes(), args);
stats.put(ret, s);
- } catch (Exception e) {
+ } catch (final Exception e) {
LOG.warning("Wake profiler could not intercept event handler: " + e.getMessage());
ret = constructor.newInstance(args);
}
} else {
ret = constructor.newInstance(args);
}
- Vertex<T> v = new Vertex<T>(ret, constructorDef, vArgs);
+ final Vertex<T> v = new Vertex<T>(ret, constructorDef, vArgs);
vertexObject.put(ret, v);
return ret;
}
@Override
- public <T> void injectionFutureInstantiated(InjectionFuture<T> arg0, T arg1) {
+ public <T> void injectionFutureInstantiated(final InjectionFuture<T> arg0, final T arg1) {
if (!futures.containsKey(arg0)) {
LOG.warning("adding future " + arg0 + " instance " + arg1);
futures.put(arg0, arg1);
@@ -171,7 +171,7 @@ public class WakeProfiler implements Aspect {
}
}
- private String jsonEscape(String s) {
+ private String jsonEscape(final String s) {
return s
.replaceAll("\\\\", "\\\\\\\\")
.replaceAll("\\\"", "\\\\\"")
@@ -184,44 +184,44 @@ public class WakeProfiler implements Aspect {
}
- private String join(String sep, List<String> tok) {
+ private String join(final String sep, final List<String> tok) {
if (tok.size() == 0) {
return "";
}
- StringBuffer sb = new StringBuffer(tok.get(0));
+ final StringBuffer sb = new StringBuffer(tok.get(0));
for (int i = 1; i < tok.size(); i++) {
sb.append(sep + tok.get(i));
}
return sb.toString();
}
- private boolean whitelist(Object o) {
+ private boolean whitelist(final Object o) {
return true;
}
public String objectGraphToString() {
- List<Vertex<?>> vertices = new ArrayList<>();
- Map<Vertex<?>, Integer> offVertex = new MonotonicHashMap<>();
+ final List<Vertex<?>> vertices = new ArrayList<>();
+ final Map<Vertex<?>, Integer> offVertex = new MonotonicHashMap<>();
- StringBuffer sb = new StringBuffer("{\"nodes\":[\n");
+ final StringBuffer sb = new StringBuffer("{\"nodes\":[\n");
- List<String> nodes = new ArrayList<String>();
- LinkedList<Vertex<?>> workQueue = new LinkedList<>();
- for (Object o : vertexObject.keySet()) {
+ final List<String> nodes = new ArrayList<String>();
+ final LinkedList<Vertex<?>> workQueue = new LinkedList<>();
+ for (final Object o : vertexObject.keySet()) {
if (whitelist(o)) {
workQueue.add(getVertex(o));
}
}
- for (Object o : futures.values()) {
+ for (final Object o : futures.values()) {
if ((!vertexObject.containsKey(o)) && whitelist(o)) {
workQueue.add(getVertex(o));
}
}
while (!workQueue.isEmpty()) {
- Vertex<?> v = workQueue.removeFirst();
+ final Vertex<?> v = workQueue.removeFirst();
LOG.warning("Work queue " + v);
- Object o = v.getObject();
+ final Object o = v.getObject();
final String s;
final String tooltip;
if (o instanceof InjectionFuture) {
@@ -240,10 +240,10 @@ public class WakeProfiler implements Aspect {
//// } else if(false && (o instanceof EventHandler || o instanceof Stage)) {
//// s = jsonEscape(v.getObject().toString());
} else {
- Stats stat = stats.get(o);
+ final Stats stat = stats.get(o);
if (stat != null) {
- long cnt = stat.messageCount.get();
- long lat = stat.sumLatency.get();
+ final long cnt = stat.messageCount.get();
+ final long lat = stat.sumLatency.get();
tooltip = ",\"count\":" + cnt + ",\"latency\":\"" + (((double) lat) / (((double) cnt) * 1000000.0) + "\"");
// quote the latency, since it might be nan
} else {
@@ -264,23 +264,23 @@ public class WakeProfiler implements Aspect {
}
sb.append(join(",\n", nodes));
sb.append("],\n\"links\":[");
- List<String> links = new ArrayList<>();
- for (Vertex<?> v : vertices) {
- for (Vertex<?> w : v.getOutEdges()) {
+ final List<String> links = new ArrayList<>();
+ for (final Vertex<?> v : vertices) {
+ for (final Vertex<?> w : v.getOutEdges()) {
LOG.fine("pointing object" + v.getObject());
LOG.fine("pointed to object " + w.getObject());
if (w.getObject() instanceof InjectionFuture) {
- Vertex<?> futureTarget = getFuture((InjectionFuture<?>) w.getObject()); //futures.get(w.getObject());
- Integer off = offVertex.get(futureTarget);
+ final Vertex<?> futureTarget = getFuture((InjectionFuture<?>) w.getObject()); //futures.get(w.getObject());
+ final Integer off = offVertex.get(futureTarget);
LOG.fine("future target " + futureTarget + " off = " + off);
if (off != null) {
links.add("{\"target\":" + offVertex.get(v) + ",\"source\":" + off + ",\"value\":" + 1.0 +
",\"back\":true}");
}
} else {
- Integer off = offVertex.get(w);
+ final Integer off = offVertex.get(w);
if (off != null) {
- Stats s = stats.get(w.getObject());
+ final Stats s = stats.get(w.getObject());
if (s != null) {
links.add("{\"source\":" + offVertex.get(v) + ",\"target\":" + off + ",\"value\":" +
(s.messageCount.get() + 3.0) + "}");
@@ -297,7 +297,7 @@ public class WakeProfiler implements Aspect {
return sb.toString();
}
- private String removeEnhancements(String simpleName) {
+ private String removeEnhancements(final String simpleName) {
return simpleName.replaceAll("\\$\\$.+$", "");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/141c7fa0/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
index c4c4460..476cc75 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/DefaultErrorHandler.java
@@ -32,7 +32,7 @@ final class DefaultErrorHandler implements EventHandler<Throwable> {
}
@Override
- public void onNext(Throwable value) {
+ public void onNext(final Throwable value) {
throw new RuntimeException("No error handler bound for RemoteManager.", value);
}
}