You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2011/02/17 22:04:35 UTC

svn commit: r1071787 - /trafficserver/traffic/trunk/proxy/InkAPI.cc

Author: zwoop
Date: Thu Feb 17 21:04:35 2011
New Revision: 1071787

URL: http://svn.apache.org/viewvc?rev=1071787&view=rev
Log:
TS-590 Improve a mime buffer memory allocation

Modified:
    trafficserver/traffic/trunk/proxy/InkAPI.cc

Modified: trafficserver/traffic/trunk/proxy/InkAPI.cc
URL: http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/InkAPI.cc?rev=1071787&r1=1071786&r2=1071787&view=diff
==============================================================================
--- trafficserver/traffic/trunk/proxy/InkAPI.cc (original)
+++ trafficserver/traffic/trunk/proxy/InkAPI.cc Thu Feb 17 21:04:35 2011
@@ -635,16 +635,17 @@ isWriteable(TSMBuffer bufp)
 /******************************************************/
 /* Allocators for field handles and standalone fields */
 /******************************************************/
-
 static MIMEFieldSDKHandle *
 sdk_alloc_field_handle(TSMBuffer bufp, MIMEHdrImpl *mh)
 {
-  sdk_assert(sdk_sanity_check_mbuffer(bufp) == TS_SUCCESS);
-
   MIMEFieldSDKHandle *handle = mHandleAllocator.alloc();
 
+  // TODO: Should remove this when memory allocation can't fail.
+  sdk_assert(sdk_sanity_check_null_ptr((void*)handle) == TS_SUCCESS);
+
   obj_init_header(handle, HDR_HEAP_OBJ_FIELD_SDK_HANDLE, sizeof(MIMEFieldSDKHandle), 0);
   handle->mh = mh;
+
   return handle;
 }