You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Jean-Sebastien Delfino <js...@apache.org> on 2006/11/21 07:21:07 UTC

[C++] Pending SDO patches available

Geoff,

I scanned our JIRAs and found a number of pending SDO patches:

 From Caroline Maynard:
https://issues.apache.org/jira/browse/TUSCANY-907 - Nov 07

 From Simon Laws:
https://issues.apache.org/jira/browse/TUSCANY-873 - Oct 18
https://issues.apache.org/jira/browse/TUSCANY-730 - Sep 18
https://issues.apache.org/jira/browse/TUSCANY-908 - Nov 08

Have these patches already been applied and the JIRA issues just need to 
be updated?
Otherwise we should really spare some time to review and commit them if 
they are still applicable.

I'd prefer somebody working on SDO to do the review, but if you review 
them and give me a green light, I'll be happy to spend the time to apply 
them tomorrow, we owe it to Caroline and Simon who spent the time to 
contribute these fixes.

-- 
Jean-Sebastien


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


Re: [C++] Pending SDO patches available

Posted by Simon Laws <si...@googlemail.com>.
On 11/22/06, Simon Laws <si...@googlemail.com> wrote:
>
>
>
> On 11/21/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> > Patch for TUSCANY-908 is applied.
> >
> > Cheers,
> >
> >
> > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > >
> > >
> > >
> > > On 21/11/06, Geoffrey Winn < geoff.winn@googlemail.com> wrote:
> > > >
> > > > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > > >
> > > > > 907 now applied.
> > > > >
> > > > > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > > > >
> > > > > > And 730 was applied by Andy in September according to the Jira
> > > > > subversion
> > > > > > log.
> > > > > >
> > > > > > 730 and 873 now resolved
> > > > > >
> > > > > >
> > > > > >  On 21/11/06, Pete Robbins <robbinspg@googlemail.com > wrote:
> > > > > > >
> > > > > > > Agh.... deja vu!
> > > > > > >
> > > > > > > I could have sworn I'd already applied 873! Done now
> > > > > > >
> > > > > > > --
> > > > > > > Pete
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Pete
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Pete
> > > >
> > > >
> > > > I've just posted a revised patch for 908 that I've tested on RHEL 3
> > and
> > > > XP/VC6.
> > > >
> > > > Regards,
> > > >
> > > > Geoff.
> > > >
> > > >
> > >
> > > Ok I'll check it out and hopefully commit it asap.
> > >
> > > --
> > > Pete
> > >
> >
> >
> >
> > --
> > Pete
> >
> > You're a star Pete. Thank you very much. We'll check out the latest
> revision and give it a spin.
>
> Simon
>
And Geoff, I neglected to say thank you for doing all the work behind the
scenes to sort out our patch for Pete to commit.

Thank you

Simon

Re: [C++] Pending SDO patches available

Posted by Simon Laws <si...@googlemail.com>.
On 11/21/06, Pete Robbins <ro...@googlemail.com> wrote:
>
> Patch for TUSCANY-908 is applied.
>
> Cheers,
>
>
> On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> >
> >
> > On 21/11/06, Geoffrey Winn <ge...@googlemail.com> wrote:
> > >
> > > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > >
> > > > 907 now applied.
> > > >
> > > > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > > >
> > > > > And 730 was applied by Andy in September according to the Jira
> > > > subversion
> > > > > log.
> > > > >
> > > > > 730 and 873 now resolved
> > > > >
> > > > >
> > > > >  On 21/11/06, Pete Robbins <robbinspg@googlemail.com > wrote:
> > > > > >
> > > > > > Agh.... deja vu!
> > > > > >
> > > > > > I could have sworn I'd already applied 873! Done now
> > > > > >
> > > > > > --
> > > > > > Pete
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Pete
> > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Pete
> > >
> > >
> > > I've just posted a revised patch for 908 that I've tested on RHEL 3
> and
> > > XP/VC6.
> > >
> > > Regards,
> > >
> > > Geoff.
> > >
> > >
> >
> > Ok I'll check it out and hopefully commit it asap.
> >
> > --
> > Pete
> >
>
>
>
> --
> Pete
>
> You're a star Pete. Thank you very much. We'll check out the latest
revision and give it a spin.

Simon

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
Patch for TUSCANY-908 is applied.

Cheers,


On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
>
>
>
> On 21/11/06, Geoffrey Winn <ge...@googlemail.com> wrote:
> >
> > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > >
> > > 907 now applied.
> > >
> > > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > >
> > > > And 730 was applied by Andy in September according to the Jira
> > > subversion
> > > > log.
> > > >
> > > > 730 and 873 now resolved
> > > >
> > > >
> > > >  On 21/11/06, Pete Robbins <robbinspg@googlemail.com > wrote:
> > > > >
> > > > > Agh.... deja vu!
> > > > >
> > > > > I could have sworn I'd already applied 873! Done now
> > > > >
> > > > > --
> > > > > Pete
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Pete
> > >
> > >
> > >
> > >
> > > --
> > > Pete
> >
> >
> > I've just posted a revised patch for 908 that I've tested on RHEL 3 and
> > XP/VC6.
> >
> > Regards,
> >
> > Geoff.
> >
> >
>
> Ok I'll check it out and hopefully commit it asap.
>
> --
> Pete
>



-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
On 21/11/06, Geoffrey Winn <ge...@googlemail.com> wrote:
>
> On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> > 907 now applied.
> >
> > On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > >
> > > And 730 was applied by Andy in September according to the Jira
> > subversion
> > > log.
> > >
> > > 730 and 873 now resolved
> > >
> > >
> > >  On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > > >
> > > > Agh.... deja vu!
> > > >
> > > > I could have sworn I'd already applied 873! Done now
> > > >
> > > > --
> > > > Pete
> > > >
> > >
> > >
> > >
> > > --
> > > Pete
> >
> >
> >
> >
> > --
> > Pete
>
>
> I've just posted a revised patch for 908 that I've tested on RHEL 3 and
> XP/VC6.
>
> Regards,
>
> Geoff.
>
>

Ok I'll check it out and hopefully commit it asap.

-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Geoffrey Winn <ge...@googlemail.com>.
On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
>
> 907 now applied.
>
> On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> > And 730 was applied by Andy in September according to the Jira
> subversion
> > log.
> >
> > 730 and 873 now resolved
> >
> >
> >  On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> > >
> > > Agh.... deja vu!
> > >
> > > I could have sworn I'd already applied 873! Done now
> > >
> > > --
> > > Pete
> > >
> >
> >
> >
> > --
> > Pete
>
>
>
>
> --
> Pete


I've just posted a revised patch for 908 that I've tested on RHEL 3 and
XP/VC6.

Regards,

Geoff.

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
907 now applied.

On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
>
> And 730 was applied by Andy in September according to the Jira subversion
> log.
>
> 730 and 873 now resolved
>
>
>  On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> > Agh.... deja vu!
> >
> > I could have sworn I'd already applied 873! Done now
> >
> > --
> > Pete
> >
>
>
>
> --
> Pete




-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
And 730 was applied by Andy in September according to the Jira subversion
log.

730 and 873 now resolved


On 21/11/06, Pete Robbins <ro...@googlemail.com> wrote:
>
> Agh.... deja vu!
>
> I could have sworn I'd already applied 873! Done now
>
> --
> Pete
>



-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
Agh.... deja vu!

I could have sworn I'd already applied 873! Done now

-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
On 21/11/06, Simon Laws <si...@googlemail.com> wrote:
>
> On 11/21/06, Pete Robbins <ro...@googlemail.com> wrote:
> >
> > On 21/11/06, Jean-Sebastien Delfino <js...@apache.org> wrote:
> > >
> > > Geoff,
> > >
> > > I scanned our JIRAs and found a number of pending SDO patches:
> > >
> > > From Caroline Maynard:
> > > https://issues.apache.org/jira/browse/TUSCANY-907 - Nov 07
> > >
> > > From Simon Laws:
> > > https://issues.apache.org/jira/browse/TUSCANY-873 - Oct 18
> > > https://issues.apache.org/jira/browse/TUSCANY-730 - Sep 18
> > > https://issues.apache.org/jira/browse/TUSCANY-908 - Nov 08
> > >
> > > Have these patches already been applied and the JIRA issues just need
> to
> > > be updated?
> > > Otherwise we should really spare some time to review and commit them
> if
> > > they are still applicable.
> > >
> > > I'd prefer somebody working on SDO to do the review, but if you review
> > > them and give me a green light, I'll be happy to spend the time to
> apply
> > > them tomorrow, we owe it to Caroline and Simon who spent the time to
> > > contribute these fixes.
> > >
> > > --
> > > Jean-Sebastien
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> > >
> > >
> > I'll take a look at them. I still haven't applied your patch that always
> > writes xmlns:xsi= when serializing. We need to put this in for now and
> fix
> > up the tests but we need a better long term solution.
> >
> > Cheers,
> >
> > --
> > Pete
> >
> > 730, 873, 908 are still required. For some reason I though 730 and 873
> had
> been done but apparently not. I know that Geoff has been looking at 908
> but
> has not committed because he is not a committer (at least doesn't have his
> account yet). We would like to include 873 and 908 (and I expect 907 but
> Caroline should comment) in our imminent (as in tomorrow)  PHP/SDO
> release.
> How do we expedite their application?



ask nicely ;-)

I'll take a look and see if I can apply them this evening.

Cheers,

Regards
>
> Simon
>
>


-- 
Pete

Re: [C++] Pending SDO patches available

Posted by Simon Laws <si...@googlemail.com>.
On 11/21/06, Pete Robbins <ro...@googlemail.com> wrote:
>
> On 21/11/06, Jean-Sebastien Delfino <js...@apache.org> wrote:
> >
> > Geoff,
> >
> > I scanned our JIRAs and found a number of pending SDO patches:
> >
> > From Caroline Maynard:
> > https://issues.apache.org/jira/browse/TUSCANY-907 - Nov 07
> >
> > From Simon Laws:
> > https://issues.apache.org/jira/browse/TUSCANY-873 - Oct 18
> > https://issues.apache.org/jira/browse/TUSCANY-730 - Sep 18
> > https://issues.apache.org/jira/browse/TUSCANY-908 - Nov 08
> >
> > Have these patches already been applied and the JIRA issues just need to
> > be updated?
> > Otherwise we should really spare some time to review and commit them if
> > they are still applicable.
> >
> > I'd prefer somebody working on SDO to do the review, but if you review
> > them and give me a green light, I'll be happy to spend the time to apply
> > them tomorrow, we owe it to Caroline and Simon who spent the time to
> > contribute these fixes.
> >
> > --
> > Jean-Sebastien
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
> >
> I'll take a look at them. I still haven't applied your patch that always
> writes xmlns:xsi= when serializing. We need to put this in for now and fix
> up the tests but we need a better long term solution.
>
> Cheers,
>
> --
> Pete
>
> 730, 873, 908 are still required. For some reason I though 730 and 873 had
been done but apparently not. I know that Geoff has been looking at 908 but
has not committed because he is not a committer (at least doesn't have his
account yet). We would like to include 873 and 908 (and I expect 907 but
Caroline should comment) in our imminent (as in tomorrow)  PHP/SDO release.
How do we expedite their application?

Regards

Simon

Re: [C++] Pending SDO patches available

Posted by Pete Robbins <ro...@googlemail.com>.
On 21/11/06, Jean-Sebastien Delfino <js...@apache.org> wrote:
>
> Geoff,
>
> I scanned our JIRAs and found a number of pending SDO patches:
>
> From Caroline Maynard:
> https://issues.apache.org/jira/browse/TUSCANY-907 - Nov 07
>
> From Simon Laws:
> https://issues.apache.org/jira/browse/TUSCANY-873 - Oct 18
> https://issues.apache.org/jira/browse/TUSCANY-730 - Sep 18
> https://issues.apache.org/jira/browse/TUSCANY-908 - Nov 08
>
> Have these patches already been applied and the JIRA issues just need to
> be updated?
> Otherwise we should really spare some time to review and commit them if
> they are still applicable.
>
> I'd prefer somebody working on SDO to do the review, but if you review
> them and give me a green light, I'll be happy to spend the time to apply
> them tomorrow, we owe it to Caroline and Simon who spent the time to
> contribute these fixes.
>
> --
> Jean-Sebastien
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
I'll take a look at them. I still haven't applied your patch that always
writes xmlns:xsi= when serializing. We need to put this in for now and fix
up the tests but we need a better long term solution.

Cheers,

-- 
Pete