You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jeffreyssmith2nd (via GitHub)" <gi...@apache.org> on 2024/07/31 19:45:16 UTC
[I] Add MetricValue that returns the max during aggregation [datafusion]
jeffreyssmith2nd opened a new issue, #11754:
URL: https://github.com/apache/datafusion/issues/11754
### Is your feature request related to a problem or challenge?
We have a scenario where we are performing multiple operations in parallel and are only interested in the one that takes the longest. Currently, `MetricValue::Time` is always summed on aggregation.
### Describe the solution you'd like
A new type, `MetricValue::MaxTime`, is implemented that functions the same as `MetricValue::Time` except on aggregation, it returns the max of the two times rather than the sum.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add MetricValue that returns the max during aggregation [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #11754:
URL: https://github.com/apache/datafusion/issues/11754#issuecomment-2269674208
I worry:
1. This is something very special
2. The addition of a new metric type solely to change how the aggregator works will cause confusion to other users of metrics
I still don't understand the usecase enough to know if this feature is something other projects would find useful or if it is very specific to our (InfluxData's) usecase
If we are only interested in the longest time interval, perhaps we can provide a custom aggregator (or a pass that walks over the metrics before aggregating them to pull out what is needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add MetricValue that returns the max during aggregation [datafusion]
Posted by "jeffreyssmith2nd (via GitHub)" <gi...@apache.org>.
jeffreyssmith2nd commented on issue #11754:
URL: https://github.com/apache/datafusion/issues/11754#issuecomment-2261320312
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org